Skip to content

Fixing: flake8 E402 and windows setup.py not working #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixing: flake8 E402 and windows setup.py not working #955

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fe67009
Fixing E402 module level import not at top of file in dateparser/docs…
gavishpoddar Jul 29, 2021
4957d10
Fixing UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in …
gavishpoddar Jul 29, 2021
b258cb8
dateparser/docs/conf.py E402 line from the pytest.ini
gavishpoddar Aug 7, 2021
9a5da27
Merge branch 'master' into fixes
gavishpoddar Aug 13, 2021
eab4ec5
updates from suggestions
gavishpoddar Aug 19, 2021
cd67a71
Merge branch 'scrapinghub:master' into fixes
gavishpoddar Aug 27, 2021
112aabb
updating tests
gavishpoddar Aug 28, 2021
841a85b
updating tests
gavishpoddar Aug 28, 2021
a2838e5
Update pytest.ini
Gallaecio Oct 4, 2021
e36d79b
Merge branch 'master' into fixes
Gallaecio Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# version is used.
sys.path.insert(0, project_root)

import dateparser
import dateparser # noqa: E402

# -- General configuration ---------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[pytest]
addopts =
--doctest-modules
--assert=plain
--assert=plain
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows "No newline at the end of file" so we need to add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kishan3, Currently dateparser doesn't have newlines at the end .ini files please suggest should I add them with this PR

Note: The tests are not failing without newline at the end of file

4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

__version__ = re.search(r"__version__.*\s*=\s*[']([^']+)[']", open('dateparser/__init__.py').read()).group(1)

introduction = re.sub(r':members:.+|..\sautomodule::.+|:class:|:func:|:ref:', '', open('docs/introduction.rst').read())
history = re.sub(r':mod:|:class:|:func:', '', open('HISTORY.rst').read())
introduction = re.sub(r':members:.+|..\sautomodule::.+|:class:|:func:|:ref:', '', open('docs/introduction.rst', encoding="utf8").read())
history = re.sub(r':mod:|:class:|:func:', '', open('HISTORY.rst', encoding="utf8").read())

test_requirements = open('tests/requirements.txt').read().splitlines()

Expand Down