fix: accessibility, tests, and a11y improvements (#868, #866, #873, #871, #864) - #981
Open
qvkap wants to merge 2 commits into
Open
fix: accessibility, tests, and a11y improvements (#868, #866, #873, #871, #864)#981qvkap wants to merge 2 commits into
qvkap wants to merge 2 commits into
Conversation
- Add title attribute to TruncatedAddress copy button (scout-off#868) - Add snapshot test for Badge component all variants (scout-off#866) - Add role="status" to PlayerCardSkeleton for screen readers (scout-off#873) - Add edge case tests for formatXlm: zero, large numbers, stroops, negatives (scout-off#871) - Add aria-label to wallet connect button (scout-off#864)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 5 open GrantFox OSS bounty issues with accessibility improvements, test coverage, and a11y fixes.
Changes
titleattribute to TruncatedAddress copy button for tooltip-on-hoverrole="status"andaria-labelto PlayerCardSkeleton for screen readersformatXlm: zero, large numbers, Stellar stroops, negatives, Infinityaria-labelto wallet connect button in WalletButtonAcceptance Criteria
titleattribute (Add title attribute to TruncatedAddress copy button #868)role="status"(Add role="status" to all loading skeleton components #873)aria-label(Add aria-label to wallet connect button in Navbar #864)Testing