Skip to content

a11y: add title attribute to TruncatedAddress copy button (Closes #868) #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

a11y: add title attribute to TruncatedAddress copy button (Closes #868) #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions __tests__/components/TruncatedAddress.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ describe('TruncatedAddress', () => {
});

expect(writeTextSpy).toHaveBeenCalledWith(ADDRESS);
expect(
screen.getByRole('button', {
name: 'Copy full address to clipboard',
}),
).toHaveAttribute('title', 'Copy full address to clipboard');
});

it('auto-hides the tooltip after the timeout elapses', () => {
Expand Down
1 change: 1 addition & 0 deletions components/ui/TruncatedAddress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export default function TruncatedAddress({
type="button"
onClick={copy}
aria-label="Copy full address to clipboard"
title="Copy full address to clipboard"
className="shrink-0 flex items-center justify-center w-6 h-6 rounded hover:bg-gray-700 transition text-gray-400 hover:text-white pointer-events-auto"
>
{copied ? (
Expand Down