feat: add title attribute to TruncatedAddress copy button (Closes #868) - #976
Open
waterWang wants to merge 1 commit into
Open
feat: add title attribute to TruncatedAddress copy button (Closes #868)#976waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
title="Copy full address to clipboard"attribute to the copy button insideTruncatedAddress.tsx. The element already had a matchingaria-label, but thetitleattribute provides a native tooltip-on-hover for sighted mouse users, closing the gap for pointer-based users who may not discover the button role via screen readers.Changes
components/ui/TruncatedAddress.tsx: Addedtitle="Copy full address to clipboard"to the<button>element.__tests__/components/TruncatedAddress.test.tsx: Added a new test case"has a title attribute on the copy button for tooltip-on-hover"that asserts thetitleattribute is present and matches the expected value.Acceptance Criteria
aria-label(already present:"Copy full address to clipboard").titleattribute with the same value is present for sighted mouse users.npm testpasses (7/7 tests).Closes #868