Skip to content

Commit

Permalink
Minor punctuation changes (hadley#516)
Browse files Browse the repository at this point in the history
* Minor punctuation change.

* minor punctuation change

* Typo correction, based on a guess about the intended meaning.

Co-authored-by: Douglas Ezra Morrison <[email protected]>
  • Loading branch information
d-morrison and d-morrison authored Sep 30, 2021
1 parent 0758675 commit 718db20
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions action-workflow.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ To understand what's going on we again start by flipping it upside down, so you

There are three basic parts to the call stack:

- The first few calls start the app in this case you just see `runApp()` but depending on how you start the app, you might see something more complicated.
- The first few calls start the app. In this case, you just see `runApp()`, but depending on how you start the app, you might see something more complicated.
For example, if you called `source()` to run the app, you might see this:

1: source
Expand Down Expand Up @@ -359,7 +359,7 @@ I'd forgotten that `TERRITORY` contained a bunch of missing values which means t
head(sales$TERRITORY == "EMEA", 25)
```

These missing values become missing rows when I use them to subset the `sales` data frame with `[` any missing values in input will be preserved in the output.
These missing values become missing rows when I use them to subset the `sales` data frame with `[`; any missing values in input will be preserved in the output.
There are lots of way to resolve this problem but I decided to use `subset()`[^action-workflow-3] because automatically removes missing values and reduces the number of times I need to type `sales`. I then double checked this actually worked:

[^action-workflow-3]: I'm using `subset()` so that my app doesn't require any other packages.
Expand Down Expand Up @@ -393,7 +393,7 @@ So I updated the app and tried again.
It still didn't work!
When I selected "NA" in the drop down, I didn't see any rows.

At this point, I figured I'd done everything I could on the console, and I needed to perform an experiment to figure out why the code inside of Shiny was working the way I expected.
At this point, I figured I'd done everything I could on the console, and I needed to perform an experiment to figure out why the code inside of Shiny wasn't working the way I expected.
I guessed that the most likely source of the problem would be in the `selected` reactive, so I added a `browser()` statement there.
(This made it a two-line reactive, so I also needed to wrap it in `{}`.)

Expand Down

0 comments on commit 718db20

Please sign in to comment.