Clean implementation of complex calculator #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 16, 2017 16:40
Also deleted the initial test class
Allows user to input 2 complex numbers and it adds them
scottjbaldwin
force-pushed
the
CleanImplementationOfComplexCalculator
branch
from
3d20921 to
3faf417
Compare
scottjbaldwin
commented
Jul 20, 2017
| @@ -29,5 +29,18 @@ public void WhenImaginaryPartSet_ItCanBeReturned() | |||
| // Assert | |||
| Assert.Equal(13, num.Imaginary); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void WhenModulousIsCalled_ItIsCalculatedAndReturned() | |||
There was a problem hiding this comment.
Should be Modulus not Modulous
| var num = new ComplexNumber { Real = 3, Imaginary = 4 }; | ||
|
|
||
| // Act | ||
| var mod = num.Modulous(); |
There was a problem hiding this comment.
Should be Modulus not Modulous
| @@ -7,5 +7,10 @@ public class ComplexNumber | |||
| public double Real { get; set; } | |||
|
|
|||
| public double Imaginary { get; set; } | |||
|
|
|||
| public double Modulous() | |||
There was a problem hiding this comment.
Should be Modulus not Modulous
|
|
||
| var c3 = c1.Add(c2); | ||
|
|
||
| Console.WriteLine("{0} + {1} = {2} with modulous {3}", c1, c2, c3, c3.Modulous()); |
There was a problem hiding this comment.
Should be Modulus not Modulous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstration of Opinionated GIT