Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies for fixing vulnerabilities #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xgbuils
Copy link

@xgbuils xgbuils commented Aug 18, 2018

#43 fix

I added npm-check dev dependency and added in test script to keep the dependencies updated.

@scott-lin
Copy link

@xgbuils, are you still working on this PR? I'm also interested in using npm-install-version, but would like the vulnerabilities fixed.

@xgbuils
Copy link
Author

xgbuils commented Aug 21, 2018

I'm not the owner of this repository. I'm waiting for a signal from @scott113341 for knowing if this repository is active. If it is, I will remove node 4 in travis-ci configuration and add node 10 to fix the CI.

I'm using npmi as alternative.

Cheers!

@scott-lin
Copy link

Thanks for the alternative suggestion! I was looking for one, but wasn't having success.

@scott-lin
Copy link

Unfortunately, npmi doesn't have the functionality I need. Would love to hear from @scott113341 about this PR.

@xgbuils
Copy link
Author

xgbuils commented Aug 25, 2018

Hi @scott-lin ,

Just for curiosity, what functionality you need?

@scott-lin
Copy link

scott-lin commented Aug 25, 2018

I was unable to install multiple versions of the same package to a single destination.

So something like this,

node_modules/some/path/package-v1
node_modules/some/path/package-v2

npm-install-version makes this very simple to do. Installing multiple versions of the same package with npmi resulted in the latter installs overwriting the previous ones since you cannot specify the destination folder name.

@xgbuils
Copy link
Author

xgbuils commented Aug 25, 2018

Ok, I had the same problem, it's simpler with this package but is possible with npmi. I asked how to install multiple versions with npmi last week and here is the answer: npmi: installing multiple versions of the same package.

For requiring the package instance just use require with the correct installation path.

Cheers!

@scott-lin
Copy link

I tried the path option with npmi before, but I believe it created a node_modules folder at the path specified, which was a no go for my project. I require multiple packages in the root node_modules folder of my application, but with custom directory names.

Thanks for sharing that though. It may be helpful for others.

Copy link

@scott-lin scott-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants