Skip to content

Commit

Permalink
allow all special option
Browse files Browse the repository at this point in the history
  • Loading branch information
scott-the-programmer committed Oct 13, 2024
1 parent c55e199 commit 1753cac
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion minikube/lib/wait_validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func ValidateWait(v map[string]bool) error {
var invalidOptions []string

for key := range v {
if !contains(standardOptions, key) || contains(specialOptions, key) {
if !contains(standardOptions, key) && !contains(specialOptions, key) {
invalidOptions = append(invalidOptions, key)
}
}
Expand Down
5 changes: 0 additions & 5 deletions minikube/lib/wait_validator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ func TestValidateWait(t *testing.T) {
input: map[string]bool{"invalid1": true, "invalid2": true, "apiserver": true},
expectedError: "invalid wait option(s): invalid1, invalid2",
},
{
name: "Special option",
input: map[string]bool{"all": true},
expectedError: "invalid wait option(s): all",
},
{
name: "Empty input",
input: map[string]bool{},
Expand Down

0 comments on commit 1753cac

Please sign in to comment.