Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in setup.py No module named 'pip.req' #934

Closed
wants to merge 8 commits into from
Closed

Fix error in setup.py No module named 'pip.req' #934

wants to merge 8 commits into from

Conversation

apg360
Copy link

@apg360 apg360 commented Nov 20, 2020

Fix the error as seen here : https://stackoverflow.com/questions/25192794/no-module-named-pip-req

Description

https://stackoverflow.com/questions/25192794/no-module-named-pip-req
Before = pip.req import parse_requirements
After =
try: # for pip >= 10
from pip._internal.req import parse_requirements
except ImportError: # for pip <= 9.0.3
from pip.req import parse_requirements

Related Issue

Link to the issue here: "Error when initial setup #933"

Motivation and Context

For a successful setup, otherwise unable to setup Bassa

How Has This Been Tested?

After fix, "python3 setup.py develop" is able to finish successfully

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

vivonk and others added 8 commits January 29, 2019 02:48
All beginning PRs should be made to develop branch, instead of master one.
Fix the error as seen here : https://stackoverflow.com/questions/25192794/no-module-named-pip-req

The Error :
# python3 setup.py develop
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    from pip.req import parse_requirements
ImportError: No module named 'pip.req'
JaDogg
JaDogg previously approved these changes Nov 21, 2020
@JaDogg
Copy link
Collaborator

JaDogg commented Nov 21, 2020

Looks reasonable. Let's wait for another review.

@kmehant
Copy link
Collaborator

kmehant commented Nov 21, 2020

@apg360 can you point your pull request to the develop branch as the master branch is not updated

@apg360 apg360 changed the base branch from master to develop November 21, 2020 20:11
@apg360 apg360 dismissed JaDogg’s stale review November 21, 2020 20:11

The base branch was changed.

@apg360
Copy link
Author

apg360 commented Nov 22, 2020

@apg360 can you point your pull request to the develop branch as the master branch is not updated

Done, thank you.

@apg360 apg360 closed this Nov 24, 2020
@apg360 apg360 deleted the patch-1 branch November 24, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants