-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: migrate from Travis to GitHub Actions #389
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed .travis.yml and shellcheck.sh - Added CI badge to README
davidhcefx
force-pushed
the
master
branch
4 times, most recently
from
March 8, 2022 00:42
ba6ae3c
to
99ee3f4
Compare
- Lots of syntax regex are poorly written and did not ends with a '$', which caused them competing with other regex rules.
- Basing on highlight.js, I enhanced the highlighting rules in various aspects. - See also: scopatz#358
- Improve colorings based on iPython (colors=Linux): - Green for exceptions and function names. - Red for keywords such as `from` and `not`. - Cyan for keywords such as `for` and `if`. - Fix empty strings not correctly highlighted. - Fix block comments not correctly highlighted when nothing follows `===`. - Add support for "TODO".
- [Batch] Fix that using "::" as comments sometimes failed - [html] Tabs give 2 spaces by default - [JS] Tabs give 2 spaces by default; Allow comments to be inline with code. - [Sh] Also highlight PKGBUILD; Fix `${v%tail}` not highlighted; Use shellcheck as linter
- Full list of directives updated from: http://nginx.org/en/docs/dirindex.html - Deleted 3 keywords, added 233 keywords
- New error message "Standard input is not a terminal" should be ignored. - nano changed its behavior to produce error messages AFTER program exited.
Closed in favor of #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that PRs later than 28 May 2021 all failed CI, plus the fact that Travis CI's free trial account has a limited quota, I think it's reasonable for us to switch to Github Actions for performing
shellcheck
.Aside from that, I added a new test
highlight_test
to check for syntax errors in all of the rcfiles, using latest GNU nano.