Add branches for different nano versions #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhcefx
pushed a commit
to davidhcefx/nanorc
that referenced
this pull request
Feb 3, 2024
Originally proposed in scopatz#370
davidhcefx
pushed a commit
to davidhcefx/nanorc
that referenced
this pull request
Apr 6, 2024
Originally proposed in scopatz#370
davidhcefx
pushed a commit
to davidhcefx/nanorc
that referenced
this pull request
Apr 6, 2024
Originally proposed in scopatz#370
davidhcefx
reviewed
Apr 6, 2024
There was a problem hiding this comment.
Found several issues when trying to apply to Nano version 2.5.3. I am currently working on solving these issues, and when it's done it should appear at galenguyer#15.
| pre-2.5.3 | ||
| pre-2.3.2 | ||
| pre-2.2.99 | ||
| pre-2.1.5 |
There was a problem hiding this comment.
These doesn't seem correct.
The 'comment' feature is introduced in 2.6.0, where 2.5.3 is its previous version.
Same apply for the 'linter', 'magic' and 'header'
| git commit -am "fix: pre-5.0: change 'brightred' to 'brightmagenta'" | ||
|
|
||
| sed -E -i.bak -e 's/\bcolor\s+latte\b/color brightred/' "${nanos[@]}" | ||
| git commit -am "fix: pre-5.0: change 'latte' to 'brightred'" |
There was a problem hiding this comment.
- The
\bcolorregex rule does not handle the case foricolor. lattecould appear in either foreground color or background color. This rule doesn't handle the background case.
| git commit -am "fix: pre-2.1.5: comment out 'header'" | ||
|
|
||
| sed -E -i.bak -e 's/^(\s*syntax\s+)([^"\s]+)(\s.*)/\1"\2"\3/' "${nanos[@]}" | ||
| git commit -am "fix: pre-2.1.5: add quotes around syntax names" |
There was a problem hiding this comment.
Beware that the whitespace group \s will NOT take effect when it's in [\s].
8 tasks
|
Superseded by galenguyer#27 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides create-branches.sh, which creates the following branches:
lattetobrightredandpurpletobrightmagenta.tabgivesnormaltowhite, andbrightnormaltobrightwhite.commentlintermagicheader, fix regex failures, add quotes aroundsyntaxnames, and comment out long string causingout of memoryerror in powershell.nanorc.Providing these branches closes #49 #104 #164 #174 #186 #189 #191 #227 #229 #236 #238 #242 #335 #349 .
Note that the existing
v2.9branch is significantly out of date withmasterper v2.9...master. Also, the name v2.9 doesn't really apply to more recent versions of nano.The pre-2.1.5 branch works on MacOS, which has nano version 2.0.6:
If this PR is accepted, I will submit a PR to update readme.md with a note to use these new branches. I will also update install.sh to use the logic in switch-branch.sh to automatically select the correct branch.