fix(patch, truncate): Get help correctly on macos #1442
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
reviewed
Sep 28, 2025
yedayak
force-pushed
the
help-usage-macos
branch
from
d759b6e to
572afb8
Compare
The usage output on macos is in bsd style, not gnu style Also other bsd types OSs
yedayak
force-pushed
the
help-usage-macos
branch
from
572afb8 to
ad62378
Compare
akinomyoga
approved these changes
Oct 4, 2025
scop
requested changes
Oct 5, 2025
Comment on lines
+53
to
+57
| if [[ $OSTYPE == *@(darwin|bsd)* ]]; then | ||
| _comp_compgen_usage | ||
| else | ||
| _comp_compgen_help | ||
| fi |
There was a problem hiding this comment.
To me, the preferred pattern for cases like these is
Suggested change
| if [[ $OSTYPE == *@(darwin|bsd)* ]]; then | |
| _comp_compgen_usage | |
| else | |
| _comp_compgen_help | |
| fi | |
| _comp_compgen_help || _comp_compgen_usage |
This frees us from hardwiring "known" OS dependencies, as well as helps with cases for which detection isn't that feasible, such as Alpine systems where a command might be a GNU one supporting long options (_comp_compgen_help applies), or a busybox one that supports only short ones (_comp_compgen_usage applies).
|
|
||
| if [[ $cur == -* ]]; then | ||
| _comp_compgen_help | ||
| if [[ $OSTYPE == *@(darwin|bsd)* ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage output on macos is in bsd style, not gnu style
Cherry picked from #1339