fix(xfreerdp): try /list:kbd also with dash syntax #1373
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused failures on recent fedoradev rawhide tests, since it seems to not be built with deprecated options like `--list-kbd` anymore. This introduces an internal utility function to list kbd layouts, which is used in two places.
akinomyoga
approved these changes
Apr 24, 2025
Comment on lines
+8
to
+9
| kbd_list=$("$1" --kbd-list 2>/dev/null) || | ||
| kbd_list=$("$1" /kbd-list 2>/dev/null) |
There was a problem hiding this comment.
I'm not familiar with xfreerdp, but according to this page, the Windows style /kbd-list seems to be preferred to the POSIX-style --kbd-list. Also, --kbd-list seems to be a synonym of /kbd-list.
Do you think we can only test /kbd-list and drop the test for --kbd-list? Conversely, if we are going to test both the styles, I think we should also check --list:kbd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused failures on recent fedoradev rawhide tests, since it seems to not be built with deprecated options like
--list-kbdanymore.This introduces an internal utility function to list kbd layouts, which is used in two places.
I'm not sure about how the usage of the function, I couldn't find other utility functions that don't just complete something right away, but I didn't look very thoroughly. Maybe returning the data through a variable like REPLY makes more sense?