Skip to content

lvm: improve completions for lvremove #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lvm: improve completions for lvremove #1335

wants to merge 2 commits into from
+5 −1

Conversation

siteshwar
Copy link

It should have a completion for /dev/mapper path.

@siteshwar
Copy link
Author

This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=2317249.

You can test it by running lvremove /d<TAB>.

akinomyoga
akinomyoga requested changes Feb 20, 2025
View reviewed changes
@akinomyoga
Copy link
Collaborator

I think we can add a test for /dev/mapper/.

siteshwar and others added 2 commits March 3, 2025 22:20
@siteshwar @akinomyoga
fix(lvm): improve completions for lvremove
2cd6911 
It should have a completion for `/dev/mapper` path.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@akinomyoga
test(lvremove): test generation of "/dev/mapper/"
e4bac86
@akinomyoga
Copy link
Collaborator

I fixed the commit message to follow Conventional Commits and added a test.

@akinomyoga akinomyoga requested a review from yedayak March 3, 2025 13:22
@yedayak
Copy link
Collaborator

yedayak commented Mar 3, 2025 •
edited
Loading

When I run complete on lvremove /dev/ma, it gets completed to lvremove /dev/mapper/ with a space at the end, which doesn't really make sense, since you will want to continue filling that in with the actual devices there.
I'm not sure what will be a better way though

scop
scop requested changes Sep 28, 2025
View reviewed changes
Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the /dev/mapper/ entry with the space after it does not feel quite right. It is also there for unprivileged users, and each tab press inserts one every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scop scop scop requested changes

@akinomyoga akinomyoga akinomyoga approved these changes

@yedayak yedayak Awaiting requested review from yedayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siteshwar @akinomyoga @yedayak @scop