Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parent file inclusion for Decomposed type #1002

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

scolladon
Copy link
Owner

Explain your changes


Now the code ensure the parent type file is included in the output folder
It just copy the parent file but do not include the parent type in the package.xml

Does this close any currently open issues?


closes #1000

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@scolladon scolladon requested a review from mehdicherf as a code owner January 31, 2025 18:29
@scolladon
Copy link
Owner Author

Hi @eheyhuron!

Could you test on your laptop and help us validate this PR please ?
You can follow those steps to easily do it locally

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (67071e2) to head (91afa4a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1028      1036    +8     
  Branches       112       113    +1     
=========================================
+ Hits          1028      1036    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the fix/decomposed-sharing-rules branch from ac66d2f to 87747de Compare February 1, 2025 12:28
Copy link

github-actions bot commented Feb 1, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

.github/workflows/on-merged-pull-request.yml Dismissed Show dismissed Hide dismissed
.github/workflows/on-pull-request.yml Dismissed Show dismissed Hide dismissed
.github/workflows/on-pull-request.yml Dismissed Show dismissed Hide dismissed
.github/workflows/reusable-build.yml Dismissed Show dismissed Hide dismissed
Copy link

github-actions bot commented Feb 1, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

mehdicherf
mehdicherf previously approved these changes Feb 3, 2025
@scolladon scolladon force-pushed the fix/decomposed-sharing-rules branch from 7dc7f09 to 88dab61 Compare February 3, 2025 09:47
Copy link

github-actions bot commented Feb 3, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

@scolladon
Copy link
Owner Author

Hi @eheyhuron!

Could you test on your laptop and help us validate this PR please ? You can follow those steps to easily do it locally

It would be greatly appreciated 😄
I'll wait till tomorrow before merging

Copy link

codeclimate bot commented Feb 3, 2025

Code Climate has analyzed commit 91afa4a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

github-actions bot commented Feb 3, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SGD Missing Dependent File on Decomposed Sharing Rule
2 participants