Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening directories recursively #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

janwilamowski
Copy link

I added a -r option to open files inside a directory (recursively). This is inspired by the similar feature in the BASH version of rmate. It also contains the -n flag to open a new Sublime window.

More explanation here: randy3k/RemoteSubl#19

@sclukey
Copy link
Owner

sclukey commented Dec 28, 2020

I don't think I will merge this. Neither the description here nor the linked issue indicate what value this provides, and apparently it doesn't work well anyway. Why not just do something like find . -type f | xargs rmate (or some more specific find to avoid files that shouldn't be opened)?

@sclukey
Copy link
Owner

sclukey commented Dec 28, 2020

Though if you wanted to make a PR specifically for adding support for opening a new window in Sublime I would be open to that. I just don't see value in the recursive option

@janwilamowski
Copy link
Author

My apologies for not providing more explanation. The idea was to open a complete project directory (with Sublime) as you would do locally, in order to keep working on the code for longer than just editing a single file. As I mentioned, this still falls short due to a few issues like preserving the folder structure. However, I think these problems are solvable so I wanted to leave my code here as a starting point. No need to merge them if you consider the feature incomplete.

I will create a separate PR for opening a new window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants