Skip to content

Conversation

nickodell
Copy link
Member

Update HiGHS to v1.10.0 in order to fix scipy/scipy#22188.

fwesselm and others added 30 commits February 19, 2025 09:57
… being used in transformNewIntegerFeasibleSolution
…sed to avoid warnings for now (there may be a more elegant way later on)
galabovaa and others added 27 commits March 19, 2025 15:27
commit 6c56a00
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 16:14:34 2025 +0000

    archive

commit 32e0460
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 16:10:49 2025 +0000

    unzipped

commit c8d7e70
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:57:21 2025 +0000

    can't test archive until release

commit ae5ccc4
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:51:57 2025 +0000

    try to test download of archive

commit a1d92f3
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:49:33 2025 +0000

    unzip

commit f73ad0a
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:45:12 2025 +0000

    path to unzipped dir

commit d6a70f8
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:43:49 2025 +0000

    copy archive to root dir

commit 2b8c85f
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:42:40 2025 +0000

    correct archive name

commit 445b549
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:41:34 2025 +0000

    try 6

commit 8eee30a
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:35:54 2025 +0000

    try 5

commit 69a8746
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:33:40 2025 +0000

    try 4

commit 074f2bb
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:32:46 2025 +0000

    try 3

commit 0989aca
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:27:07 2025 +0000

    try 2

commit f0e1362
Author: Ivet Galabova <[email protected]>
Date:   Wed Mar 19 15:19:22 2025 +0000

    try
Added optional FindCUDAConf for running on GPU cluster
@rgommers
Copy link
Member

Thanks! I assume this is draft because you want a SciPy PR with green CI before merging this?

@nickodell
Copy link
Member Author

Thanks! I assume this is draft because you want a SciPy PR with green CI before merging this?

It's a draft because there are a few things I am not sure how to fix. Right now I get some compiler warnings from Highs:

[1242/1450] Compiling C++ object scipy/optimize/_highspy/_...u.so.p/.._.._.._subprojects_highs_src_highs_bindings.cpp.o
In file included from ../subprojects/highs/src/lp_data/HighsAnalysis.h:17,
                 from ../subprojects/highs/src/util/HFactor.h:21,
                 from ../subprojects/highs/src/simplex/HighsSimplexAnalysis.h:22,
                 from ../subprojects/highs/src/simplex/HSimplexNla.h:17,
                 from ../subprojects/highs/src/simplex/HEkk.h:15,
                 from ../subprojects/highs/src/lp_data/HighsLpSolverObject.h:16,
                 from ../subprojects/highs/src/lp_data/HighsRanging.h:16,
                 from ../subprojects/highs/src/Highs.h:19,
                 from ../subprojects/highs/src/highs_bindings.cpp:9:
../subprojects/highs/src/util/HighsTimer.h: In constructor 'HighsTimer::HighsTimer()':
../subprojects/highs/src/util/HighsTimer.h:46:14: warning: unused variable 'i_clock' [-Wunused-variable]
   46 |     HighsInt i_clock = clock_def("Run HiGHS");
      |              ^~~~~~~
../subprojects/highs/src/util/HighsTimer.h: In member function 'void HighsTimer::resetHighsTimer()':
../subprojects/highs/src/util/HighsTimer.h:103:14: warning: unused variable 'i_clock' [-Wunused-variable]
  103 |     HighsInt i_clock = clock_def("Run HiGHS");
      |              ^~~~~~~
../subprojects/highs/src/highs_bindings.cpp: In function 'std::tuple<HighsStatus, pybind11::array_t<double, 17>, int, pybind11::array_t<int, 17> > highs_getReducedRowSparse(Highs*, HighsInt)':
../subprojects/highs/src/highs_bindings.cpp:335:12: warning: unused variable 'num_col' [-Wunused-variable]
  335 |   HighsInt num_col = h->getNumCol();
      |            ^~~~~~~

I don't quite understand why these warnings appear, because our meson configuration ought to be ignoring them.

@rgommers
Copy link
Member

I don't quite understand why these warnings appear, because our meson configuration ought to be ignoring them.

Compile flags like -Wno-unused-variable are per target, and the highspy/_core extension module doesn't have any warning suppression flags. You can see this in the meson.build file, and also in the generated build/build.ninja (just search for highs_bindings.cpp there).

To fix it, we need an extra commit here. Ideally it's fixed upstream and then that fix included here. It's fine to do it out of order and fix it first here though, if that's easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: optimize.milp: segfault from HiGHS

9 participants