-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to run script on AWS Lambda #1
Open
spenczar
wants to merge
11
commits into
master
Choose a base branch
from
lambda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a big commit, centered around running dontspendtoomuch.py on Lambda. One part of it is writing Terraform to define infrastructure. That terraform file shouldn't live in this repo for long; it should move into the central scimma/aws-dev repository for a consistent state management strategy. But for now, here is fine. Another part of it is work to create Lambda-style build artifacts. That's all done inside Make. The idea is just that we need to ship up a zip archive with the script and all of its dependencies. Finally, there are some little changes to dontspendtoomuch.py. An entrypoint for lambda invocations is added, and a barebones send-to-slack function is added. That function doesn't do any formatting so it's not very useful just yet. As of this commit, I have tfstate files stored locally. I am not sure it's worth setting up state management since we'll be moving the .tf file over to a different repo where that work is already done.
spenczar
commented
Apr 22, 2020
allowed_account_ids = ["585193511743"] | ||
} | ||
|
||
resource "aws_secretsmanager_secret" "slack_hook_url" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: i had to create the slack webhook by hand, and inserted it into the AWS console by hand.
… in the SLACK inventory -- table still does not render in neat columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big commit, centered around running dontspendtoomuch.py on Lambda. One part of it is writing Terraform to define infrastructure. That terraform file shouldn't live in this repo for long; it should move into the central scimma/aws-dev repository for a consistent state management strategy. But for now, here is fine.
Another part of it is work to create Lambda-style build artifacts. That's all done inside Make. The idea is just that we need to ship up a zip archive with the script and all of its dependencies.
Finally, there are some little changes to dontspendtoomuch.py. An entrypoint for lambda invocations is added, and a barebones send-to-slack function is added. That function doesn't do any formatting so it's not very useful just yet.
As of this commit, I have tfstate files stored locally. I am not sure it's worth setting up state management since we'll be moving the .tf file over to a different repo where that work is already done.