Add .h5 in extension using the 'same' reference in scil_tractogram_commit#1277
Closed
gagnonanthony wants to merge 1 commit intoscilus:masterfrom
Closed
Add .h5 in extension using the 'same' reference in scil_tractogram_commit#1277gagnonanthony wants to merge 1 commit intoscilus:masterfrom
.h5 in extension using the 'same' reference in scil_tractogram_commit#1277gagnonanthony wants to merge 1 commit intoscilus:masterfrom
Conversation
Contributor
|
Does the .h5 have its own reference ? We commit omit one for TRKs as they include the ref's affine in their header. What about these .h5 ? |
Contributor
|
Also a duplicate of #1279 ? |
Member
Author
|
Sorry I missed this yesterday, but yepp, it was included in #1279. I'm gonna close this one here, thanks @AntoineTheb ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
Reference was set to 'same' only if the input tractogram was a
.trk, which made the following saving function fail. Simply added the.h5in the extension possibilities.Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
error message:
Checklist