chore: Add sp-repo-review recommendations for pytest #203
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 72.51% 72.51%
=======================================
Files 4 4
Lines 131 131
=======================================
Hits 95 95
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewfeickert
force-pushed
the
chore/add-pytest-configuration
branch
from
32d6bbc to
ad143eb
Compare
matthewfeickert
force-pushed
the
chore/add-pytest-configuration
branch
from
ad143eb to
429e274
Compare
pyproject.toml
Outdated
| addopts = "-v -ra" | ||
| addopts = ["-v", "-ra", "--strict-config", "--strict-markers"] | ||
| norecursedirs = ["src"] | ||
| minversion = "9" |
There was a problem hiding this comment.
If we require 9, we could go ahead and use the new nicer configuration style ([tool.pytest], strict=true, etc).
There was a problem hiding this comment.
@henryiii that sounds great! I don't know that off the top of my head, so I'll look it up and revise this.
There was a problem hiding this comment.
There was a problem hiding this comment.
You can also see here an example (https://github.com/scipp-atlas/pyhs3/blob/main/pyproject.toml#L86-L101)
There was a problem hiding this comment.
* Update minimum pytest version to v9. * Use modern pytest configuration in [tool.pytest] table. - c.f. https://learn.scientific-python.org/development/guides/pytest/ Co-authored-by: Henry Schreiner <[email protected]>
matthewfeickert
force-pushed
the
chore/add-pytest-configuration
branch
from
429e274 to
faec265
Compare
3 participants
Requires PR #201 to go in first.