-
Notifications
You must be signed in to change notification settings - Fork 22
docs: JOSS paper #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: JOSS paper #337
Conversation
🏎️ Benchmark Comparison |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 509 509
=========================================
Hits 509 509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 Let me know if you would like any reviews of this in advance, as I obviously won't be able to serve as the JOSS editor for this submission. :) |
- remove equal-contrib - add correspinding author - bump date
eduardo-rodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @APN-Pucky. I left a few little suggestions. I found the paper in excellent shape. Seems you can submit next week to start it nicely 👍!
Thank you for this work!
Co-authored-by: Eduardo Rodrigues <[email protected]>
Thank you for your reviews. I will probably merge this before I submit it, because then the official RTD are also updated for the review. Maybe even a 1.0.2 release for the typing change (#341). |
I think that would be great, as having updated documentation is a huge benefit in these reviews.
While not necessary, that would be nice for the reviewers as if things are well typed then when reviewing use in code that is an improvement for them. |
Closes: #320