Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Weighted cutflow #1272

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NJManganelli
Copy link
Collaborator

This PR adds an (opinionated) take on adding weighted cutflows to coffea, permitting the cutflow to be instantiated with a Weights object and a weights modifier (i.e. a weights variation name, as in Weights.weights("jesUp"))

@NJManganelli NJManganelli changed the title [Feature] Weighted cutflow feat: Weighted cutflow Feb 7, 2025
@lgray
Copy link
Collaborator

lgray commented Feb 7, 2025

FAILED tests/test_analysis_tools.py::test_packed_selection_cutflow_dak[True] - TypeError: meta must be an instance of an Awkward Array, not <class 'module'>.
FAILED tests/test_analysis_tools.py::test_packed_selection_cutflow_dak[False] - TypeError: meta must be an instance of an Awkward Array, not <class 'module'>.
FAILED tests/test_analysis_tools.py::test_packed_selection_cutflow_dak_uproot_only[True] - TypeError: meta must be an instance of an Awkward Array, not <class 'module'>.
FAILED tests/test_analysis_tools.py::test_packed_selection_cutflow_dak_uproot_only[False] - TypeError: meta must be an instance of an Awkward Array, not <class 'module'>.

@NJManganelli
Copy link
Collaborator Author

Aye, those failures are the attempt to use fill_flattened in dask which doesn't currently work, so it will be rolled-back to manual flattening for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants