Skip to content

fix: handle FutureWarning for deprecated feather#4198

Merged
ianna merged 6 commits into
mainfrom
ianna/fix_deprecated_feather_warning
Jul 11, 2026
Merged

fix: handle FutureWarning for deprecated feather#4198
ianna merged 6 commits into
mainfrom
ianna/fix_deprecated_feather_warning

Conversation

@ianna

@ianna ianna commented Jul 10, 2026

Copy link
Copy Markdown
Member

Suppress FutureWarning when using deprecated write_feather.

Suppress FutureWarning when using deprecated write_feather.
@github-actions github-actions Bot added the type/fix PR title type: fix (set automatically) label Jul 10, 2026
@ianna
ianna requested a review from TaiSakuma July 10, 2026 09:50
ianna and others added 2 commits July 10, 2026 12:09
Suppress FutureWarning for deprecated pyarrow functions.
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.55%. Comparing base (05ba251) to head (1ff99cd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/operations/ak_from_feather.py 100.00% <100.00%> (ø)
src/awkward/operations/ak_to_feather.py 85.18% <100.00%> (+1.85%) ⬆️

@github-actions

Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR4198

@ianna ianna left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TaiSakuma -- I'm done with this PR. Please review and merge it at your earliest convenience. Thanks!

@TaiSakuma TaiSakuma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.

I will paste findings by Claude.


The warning suppression is correct: it filters by both message= and category=FutureWarning around a single call, and the regexes match the upstream strings in apache/arrow#49590. With filterwarnings = ["error"] in pyproject.toml, this prevents a test failure once CI resolves pyarrow >= 24.0.0.

Two follow-ups, both out of scope here:

  1. Pre-existing bug in from_feather: read_table(path, columns, use_threads, memory_map) forwards positionally, but read_table's parameter order is (source, columns, memory_map, use_threads). So use_threads and memory_map are swapped, inverting the documented defaults. Keyword arguments fix it.

  2. pyarrow.feather is deprecated; to_feather / from_feather should move to pyarrow.ipc before the API is removed. Note pyarrow.ipc does not compress by default, unlike write_feather.

🤖 Generated with Claude Code


@ikrommyd

ikrommyd commented Jul 11, 2026

Copy link
Copy Markdown
Member

You can also add this filter in pyproject.toml and avoid modifying tests completely. Smaller change.

@ianna

ianna commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

You can also add this filter in pyproject.toml and avoid modifying tests completely. Smaller change.

Now that @pranjan2023 is working on a proper implementation I don’t think we should spend more time on fixing the temporary fix.

@ianna
ianna merged commit f8afd80 into main Jul 11, 2026
38 checks passed
@ianna
ianna deleted the ianna/fix_deprecated_feather_warning branch July 11, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix PR title type: fix (set automatically)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants