Solves issue #29 and improves PR #18#35
Open
BePo65 wants to merge 17 commits intoschlosser:masterfrom
Open
Conversation
Market share of IE is less than 1% and IE does not support classes 'style.type' is deprecated and today should be avoided
Prepare test to use es modules
Classes are mocved to single files to make modifications easier to comprehend; single files will be merged later on.
Needed to enable derived classes to overwrite generation of content of <figure> tag.
This way derived ProgressiveImage classes can be used to customize the content of the created <figure> tag.
Makes it possible to create an example for customized layouts
BREAKING CHANGE: pig.js and pig.min.js moved to dist/umd directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates PIG to enable customization of ProgressiveImage and thereby extend the html created within each <figure> tag.
I did not merge all my commits to make it easier to review the changes.
Here is what I did:
Refactoring
Features
source file
umd version
packed esm version
Tooling
BREAKING CHANGE
I moved code used for production systems to /dist (umd) or /dist/esm (esm) directory, to make it easier to publish the packages to npm.
But besides the new location of the code, using the basic (uncustomized) version did not change.