Add support for custom ProgressiveImage equivalents#18
Open
Ortham wants to merge 2 commits intoschlosser:masterfrom
Open
Add support for custom ProgressiveImage equivalents#18Ortham wants to merge 2 commits intoschlosser:masterfrom
Ortham wants to merge 2 commits intoschlosser:masterfrom
Conversation
The imageType option can be set to another prototype that provides the
same API as ProgressiveImage, which can be expressed in TypeScript as
```
interface ProgressiveImage {
aspectRatio: number;
style: ProgressiveImageStyle;
load(): void;
hide(): void;
}
interface ProgressiveImageStyle {
width: number;
height: number;
translateX: number;
translateY: number;
transition: string;
}
```
They're <img /> elements for ProgressiveImage, but might not be for custom alternatives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is, pig.js doesn't give you any control over what is rendered on the grid, beyond specifying a filename and aspect ratio for each image. This adds the ability to specify an alternative implementation of
ProgressiveImageto display images with.Implementations must still provide the same interface as
ProgressiveImage, which according to whatPiguses is (in TypeScript):