Restore number of allocated voice slots on OOM error #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an OOM error happens when trying to allocate more slots for voices, tsf_note_on returned failure, properly, but it also didn't undo the increase in voiceNum (which didn't happen). This would cause an overflow/overwrite error on the next note_on call. In most desktop systems this OOM isn't going to happen, but I'm using this on embedded CPUs with as little as 40KB of heap so there it does show up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an OOM error happens when trying to allocate more slots for voices, tsf_note_on returned failure, properly, but it also didn't undo the increase in voiceNum (which didn't happen). This would cause an overflow/overwrite error on the next note_on call.
In most desktop systems this OOM isn't going to happen, but I'm using this on embedded CPUs with as little as 40KB of heap so there it does show up.