Improved snippet in AsInstanceOf

scapegoat-scala · Jul 28, 2014 · 264f5f5 · 264f5f5
1 parent e852b57
commit 264f5f5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/screenshot1.png b/screenshot1.png
diff --git a/src/main/scala/com/sksamuel/scapegoat/inspections/AsInstanceOf.scala b/src/main/scala/com/sksamuel/scapegoat/inspections/AsInstanceOf.scala
@@ -1,18 +1,18 @@
 package com.sksamuel.scapegoat.inspections
 
-import com.sksamuel.scapegoat.{Levels, Inspection, Reporter}
-
-import scala.reflect.runtime._
-import scala.reflect.runtime.universe._
+import com.sksamuel.scapegoat.{Inspection, Levels, Reporter}
 
 /** @author Stephen Samuel */
 class AsInstanceOf extends Inspection {
-  override def traverser(reporter: Reporter) = new universe.Traverser {
-    override def traverse(tree: universe.Tree): Unit = {
+
+  import scala.reflect.runtime.universe._
+
+  override def traverser(reporter: Reporter) = new Traverser {
+    override def traverse(tree: Tree): Unit = {
       tree match {
-        case Select(_, TermName("asInstanceOf")) =>
+        case TypeApply(Select(_, TermName("asInstanceOf")), _) =>
           reporter.warn("Use of asInstanceOf", tree, Levels.Warning,
-            "asInstanceOf used near " + tree.toString().take(500))
+            "asInstanceOf used near " + tree.toString().take(500) + ". Consider using collect.")
         case DefDef(modifiers, _, _, _, _, _) if modifiers.hasFlag(Flag.SYNTHETIC) => // no further
         case _ => super.traverse(tree)
       }

diff --git a/src/main/scala/com/sksamuel/scapegoat/inspections/CatchNpe.scala b/src/main/scala/com/sksamuel/scapegoat/inspections/CatchNpe.scala
@@ -2,8 +2,6 @@ package com.sksamuel.scapegoat.inspections
 
 import com.sksamuel.scapegoat.{Inspection, Levels, Reporter}
 
-import scala.reflect.runtime._
-
 /** @author Stephen Samuel */
 class CatchNpe extends Inspection {