Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added close serial port to device_destruct in unix serial.cc #71

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Added close serial port to device_destruct in unix serial.cc #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed0e1d
Added close serial port to device_destruct in unix serial.cc
kent-williams Apr 16, 2017
c7cafac
Added assertion to file descriptor close
kent-williams Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libsweep/src/unix/serial.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,11 @@ void device_destruct(device_s serial) {

error_s ignore = nullptr;
device_flush(serial, &ignore);

if (close(serial->fd) == -1) {
SWEEP_ASSERT(false && "closing file descriptor during destruct failed");
}

(void)ignore; // nothing we can do here

delete serial;
Expand Down