Skip to content

Conversation

@dvasilas
Copy link
Collaborator

This PR implements S3 integration to enable log-courier to write log objects to S3.

It sets up Metadata, Vault, and CloudServer in the CI for testing.



cloudserver:
image: ghcr.io/scality/cloudserver:7.70.77

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: ghcr.io/scality/cloudserver:7.70.77
image: ghcr.io/scality/cloudserver:9.0.32

https://github.com/scality/Federation/blob/development/9.5/group_vars/all#L203

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we cannot directly bump to version 9, we need to update the cloud server config. I created https://scality.atlassian.net/browse/WKBCH-9 to do it separately.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.69%. Comparing base (74ff315) to head (a0b80c4).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/logcourier/config.go 33.33% 2 Missing and 2 partials ⚠️
pkg/s3/client.go 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
pkg/s3/uploader.go 100.00% <100.00%> (ø)
pkg/testutil/clickhouse.go 88.26% <100.00%> (+0.06%) ⬆️
pkg/s3/client.go 94.11% <94.11%> (ø)
pkg/logcourier/config.go 80.00% <33.33%> (-20.00%) ⬇️
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   84.22%   84.69%   +0.46%     
==========================================
  Files           9       11       +2     
  Lines         450      503      +53     
==========================================
+ Hits          379      426      +47     
- Misses         52       55       +3     
- Partials       19       22       +3     
Flag Coverage Δ
unit 84.69% <90.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We use S3 client's build-in retry mechanism
And make retry configuration customizable.
@dvasilas dvasilas merged commit 7a0f778 into main Nov 6, 2025
3 checks passed
@dvasilas dvasilas deleted the improvement/LOGC-6 branch November 6, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants