Skip to content

Conversation

@lisalupi
Copy link
Collaborator

Summary

Type

  • Bug

Summarize concisely:

What is expected?

SelectInput:

  • click outside should work in every context
  • fix placeholder alignment when small

Before:
image

After:
image

@lisalupi lisalupi requested a review from a team November 26, 2025 09:38
@lisalupi lisalupi self-assigned this Nov 26, 2025
@lisalupi lisalupi requested review from Echo-IV and johnrazeur and removed request for a team November 26, 2025 09:38
@lisalupi lisalupi added the bug Something isn't working label Nov 26, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

🦋 Changeset detected

Latest commit: 57047af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi force-pushed the fix/select-input-close branch from 62c8fdf to a64890a Compare November 26, 2025 09:39
@lisalupi lisalupi changed the title fix(SelectInput): click oustide should work and size fix #5491 fix(SelectInput): click oustide should work and size fix #5491 Nov 26, 2025
@lisalupi lisalupi changed the title fix(SelectInput): click oustide should work and size fix #5491 fix(SelectInput): click oustide should work and size fix Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.64%. Comparing base (9bcbc09) to head (57047af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5828   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         341      341           
  Lines        7112     7112           
  Branches     2777     2761   -16     
=======================================
  Hits         6518     6518           
  Misses        594      594           
Files with missing lines Coverage Δ
packages/ui/src/components/Popup/index.tsx 92.37% <100.00%> (ø)
...components/SelectInput/components/selectBar.css.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcbc09...57047af. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lisalupi lisalupi force-pushed the fix/select-input-close branch from ebfd3f6 to 57047af Compare November 27, 2025 09:15
@lisalupi lisalupi merged commit 7bde3d9 into main Nov 27, 2025
17 checks passed
@lisalupi lisalupi deleted the fix/select-input-close branch November 27, 2025 09:26
@scaleway-bot scaleway-bot mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants