fix(SelectInput): click oustide should work and size fix #5491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisalupi
requested review from
DorianMaliszewski
and removed request for
a team
lisalupi
requested review from
johnrazeur,
a team and
matthprost
as code owners
🦋 Changeset detectedLatest commit: 8afb4da The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisalupi
force-pushed
the
fix/click-close-select-input
branch
from
84c804e to
7b20bee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## beta #5491 +/- ##
==========================================
+ Coverage 92.19% 92.22% +0.02%
==========================================
Files 274 283 +9
Lines 7807 7752 -55
Branches 3264 3212 -52
==========================================
- Hits 7198 7149 -49
+ Misses 609 603 -6
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lisalupi
force-pushed
the
fix/click-close-select-input
branch
from
7b20bee to
0f82f61
Compare
matthprost
requested changes
Sep 3, 2025
Comment on lines
+726
to
+748
| const handleClickOutside = useCallback( | ||
| (event: MouseEvent) => { | ||
| if ( | ||
| event.target instanceof Node && | ||
| ref.current && | ||
| !ref.current.contains(event.target) && | ||
| refSelect.current && | ||
| !refSelect.current.contains(event.target) | ||
| ) { | ||
| setIsDropdownVisible(false) | ||
| } | ||
| }, | ||
| [setIsDropdownVisible, refSelect], | ||
| ) | ||
|
|
||
| useEffect(() => { | ||
| document.addEventListener('mouseup', handleClickOutside) | ||
|
|
||
| return () => { | ||
| document.removeEventListener('mouseup', handleClickOutside) | ||
| } | ||
| }, [handleClickOutside]) | ||
|
|
There was a problem hiding this comment.
This is already handled into the popup component it makes a duplicate. Maybe the issue is related to popup?
lisalupi
force-pushed
the
fix/click-close-select-input
branch
2 times, most recently
from
ea6b2fc to
4077f70
Compare
matthprost
force-pushed
the
beta
branch
2 times, most recently
from
941b320 to
a6ca909
Compare
matthprost
force-pushed
the
beta
branch
4 times, most recently
from
4357b70 to
2806dad
Compare
lisalupi
force-pushed
the
fix/click-close-select-input
branch
from
4077f70 to
1d9035a
Compare
lisalupi
force-pushed
the
fix/click-close-select-input
branch
from
1d9035a to
0d0ce70
Compare
lisalupi
force-pushed
the
fix/click-close-select-input
branch
from
0d0ce70 to
8afb4da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
SelectInput:Before:
After:
