Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tooltip): wrong arrow alignement due to popup #4690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Arrow of the tooltip is sometimes miss aligned with the tooltip itself.

Relevant logs and/or screenshots

Page Before After
url Capture d’écran 2024-12-18 à 10 54 41 Screenshot 2025-01-20 at 11 32 43

@matthprost matthprost added the bug Something isn't working label Jan 20, 2025
@matthprost matthprost requested a review from a team January 20, 2025 10:46
@matthprost matthprost self-assigned this Jan 20, 2025
@matthprost matthprost requested review from johnrazeur and removed request for a team January 20, 2025 10:46
@matthprost matthprost requested a review from lisalupi as a code owner January 20, 2025 10:46
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: d2cc064

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (7ba780c) to head (d2cc064).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4690      +/-   ##
==========================================
+ Coverage   89.20%   89.23%   +0.02%     
==========================================
  Files         227      227              
  Lines        7932     7952      +20     
  Branches     3647     3659      +12     
==========================================
+ Hits         7076     7096      +20     
  Misses        856      856              
Files with missing lines Coverage Δ
packages/ui/src/components/Popup/helpers.ts 83.20% <100.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba780c...d2cc064. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants