Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RowV2): new component #2300

Merged
merged 4 commits into from
Mar 20, 2023
Merged

feat(RowV2): new component #2300

merged 4 commits into from
Mar 20, 2023

Conversation

fabienhebert
Copy link
Collaborator

Summary

Type

  • Feature

Summarise concisely:

A utility/display component to simplify our usage :

  • We can replace Grid/Row/Col, by using multiples RowV2 (check story example)
  • We can replace Stack with styled children, when each children should take a specific width

The component is based on display:grid and templateColumn receive a grid-template-column value

@fabienhebert fabienhebert added the enhancement New feature or request label Mar 15, 2023
@fabienhebert fabienhebert self-assigned this Mar 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

⚠️ No Changeset found

Latest commit: 9a57d8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

size-limit report 📦

Path Size
packages/form/dist/index.js, packages/themes/dist/index.js, packages/form/dist/helpers/pickValidators.js, packages/form/dist/hooks/useFormField.js, packages/form/dist/hooks/useOnFieldChange.js, packages/form/dist/hooks/useValidation.js, packages/form/dist/validators/index.js, packages/form/dist/validators/max.js, packages/form/dist/validators/maxDate.js, packages/form/dist/validators/maxLength.js, packages/form/dist/validators/min.js, packages/form/dist/validators/minDate.js, packages/form/dist/validators/minLength.js, packages/form/dist/validators/regex.js, packages/form/dist/validators/required.js, packages/ui/dist/src/index.js, packages/form/dist/components/CheckboxField/index.js, packages/form/dist/components/DateField/index.js, packages/form/dist/components/Form/index.js, packages/form/dist/components/NumberInputField/index.js, packages/form/dist/components/RadioField/index.js, packages/form/dist/components/SelectInputField/index.js, packages/form/dist/components/SelectableCardField/index.js, packages/form/dist/components/Submit/index.js, packages/form/dist/components/SubmitErrorAlert/index.js, packages/form/dist/components/TagInputField/index.js, packages/form/dist/components/TextInputField/index.js, packages/form/dist/components/TimeField/index.js, packages/form/dist/components/ToggleField/index.js, packages/form/dist/providers/ErrorContext/index.js, packages/themes/dist/themes/console/dark.js, packages/themes/dist/themes/console/index.js, packages/themes/dist/themes/console/light.js, packages/ui/dist/react-datepicker/dist/react-datepicker.min.css.js, packages/ui/dist/react-toastify/dist/ReactToastify.min.css.js, packages/ui/dist/src/helpers/isJSON.js, packages/ui/dist/src/helpers/legend.js, packages/ui/dist/src/helpers/numbers.js, packages/ui/dist/src/helpers/recursivelyGetChildrenString.js, packages/ui/dist/src/theme/index.js, packages/ui/dist/src/utils/animations.js, packages/ui/dist/src/utils/capitalize.js, packages/ui/dist/src/utils/ids.js, packages/ui/dist/src/utils/normalize.js, packages/ui/dist/src/utils/orderBy.js, packages/ui/dist/src/components/ActionBar/index.js, packages/ui/dist/src/components/Alert/index.js, packages/ui/dist/src/components/Avatar/index.js, packages/ui/dist/src/components/Badge/index.js, packages/ui/dist/src/components/BarChart/Tooltip.js, packages/ui/dist/src/components/BarChart/index.js, packages/ui/dist/src/components/BarStack/index.js, packages/ui/dist/src/components/BorderedBox/index.js, packages/ui/dist/src/components/Breadcrumbs/index.js, packages/ui/dist/src/components/Bullet/index.js, packages/ui/dist/src/components/Button/index.js, packages/ui/dist/src/components/Carousel/index.js, packages/ui/dist/src/components/Checkbox/index.js, packages/ui/dist/src/components/Container/index.js, packages/ui/dist/src/components/CopyButton/index.js, packages/ui/dist/src/components/DateInput/index.js, packages/ui/dist/src/components/Expandable/index.js, packages/ui/dist/src/components/Grid/Col.js, packages/ui/dist/src/components/Grid/Grid.js, packages/ui/dist/src/components/Grid/Row.js, packages/ui/dist/src/components/Icon/index.js, packages/ui/dist/src/components/LineChart/CustomLegend.js, packages/ui/dist/src/components/LineChart/Tooltip.js, packages/ui/dist/src/components/LineChart/helpers.js, packages/ui/dist/src/components/LineChart/index.js, packages/ui/dist/src/components/Link/index.js, packages/ui/dist/src/components/List/Cell.js, packages/ui/dist/src/components/List/LoadingSkeleton.js, packages/ui/dist/src/components/List/SelectBar.js, packages/ui/dist/src/components/List/SortIcon.js, packages/ui/dist/src/components/List/context.js, packages/ui/dist/src/components/List/index.js, packages/ui/dist/src/components/ListV2/Body.js, packages/ui/dist/src/components/ListV2/Cell.js, packages/ui/dist/src/components/ListV2/HeaderCell.js, packages/ui/dist/src/components/ListV2/HeaderRow.js, packages/ui/dist/src/components/ListV2/ListContext.js, packages/ui/dist/src/components/ListV2/Row.js, packages/ui/dist/src/components/ListV2/SelectBar.js, packages/ui/dist/src/components/ListV2/SkeletonRows.js, packages/ui/dist/src/components/ListV2/constants.js, packages/ui/dist/src/components/ListV2/index.js, packages/ui/dist/src/components/Loader/index.js, packages/ui/dist/src/components/Menu/Item.js, packages/ui/dist/src/components/Menu/index.js, packages/ui/dist/src/components/Modal/index.js, packages/ui/dist/src/components/Notice/index.js, packages/ui/dist/src/components/NumberInput/index.js, packages/ui/dist/src/components/Pagination/getPageNumbers.js, packages/ui/dist/src/components/Pagination/index.js, packages/ui/dist/src/components/Pagination/usePagination.js, packages/ui/dist/src/components/PaginationV2/getPageNumbers.js, packages/ui/dist/src/components/PaginationV2/index.js, packages/ui/dist/src/components/PasswordCheck/index.js, packages/ui/dist/src/components/PasswordStrengthMeter/index.js, packages/ui/dist/src/components/PieChart/Legends.js, packages/ui/dist/src/components/PieChart/Tooltip.js, packages/ui/dist/src/components/PieChart/index.js, packages/ui/dist/src/components/PieChart/patterns.js, packages/ui/dist/src/components/ProgressBar/index.js, packages/ui/dist/src/components/ProgressionButton/index.js, packages/ui/dist/src/components/Radio/index.js, packages/ui/dist/src/components/SelectInput/index.js, packages/ui/dist/src/components/SelectableCard/index.js, packages/ui/dist/src/components/Separator/index.js, packages/ui/dist/src/components/Skeleton/Block.js, packages/ui/dist/src/components/Skeleton/Blocks.js, packages/ui/dist/src/components/Skeleton/BoxWithIcon.js, packages/ui/dist/src/components/Skeleton/Donut.js, packages/ui/dist/src/components/Skeleton/IconSkeleton.js, packages/ui/dist/src/components/Skeleton/Line.js, packages/ui/dist/src/components/Skeleton/List.js, packages/ui/dist/src/components/Skeleton/Slider.js, packages/ui/dist/src/components/Skeleton/index.js, packages/ui/dist/src/components/Snippet/index.js, packages/ui/dist/src/components/Stack/index.js, packages/ui/dist/src/components/Status/index.js, packages/ui/dist/src/components/StepList/index.js, packages/ui/dist/src/components/Stepper/index.js, packages/ui/dist/src/components/SwitchButton/FocusOverlay.js, packages/ui/dist/src/components/SwitchButton/index.js, packages/ui/dist/src/components/Table/index.js, packages/ui/dist/src/components/Tabs/Tab.js, packages/ui/dist/src/components/Tabs/TabMenu.js, packages/ui/dist/src/components/Tabs/TabMenuItem.js, packages/ui/dist/src/components/Tabs/TabsContext.js, packages/ui/dist/src/components/Tabs/index.js, packages/ui/dist/src/components/Tag/index.js, packages/ui/dist/src/components/TagInput/index.js, packages/ui/dist/src/components/TagList/index.js, packages/ui/dist/src/components/Text/index.js, packages/ui/dist/src/components/TextInput/index.js, packages/ui/dist/src/components/TimeInput/index.js, packages/ui/dist/src/components/Toaster/index.js, packages/ui/dist/src/components/Toggle/index.js, packages/ui/dist/src/components/Tooltip/helpers.js, packages/ui/dist/src/components/Tooltip/index.js, packages/ui/dist/src/components/UnitInput/index.js, packages/ui/dist/src/components/VerificationCode/index.js, packages/ui/dist/src/utils/responsive/Breakpoint.js, packages/ui/dist/src/utils/responsive/utilities.js, packages/ui/dist/src/components/List/variants/index.js, packages/ui/dist/src/components/List/variants/variantExplorer.js, packages/ui/dist/src/components/List/variants/variantProduct.js, packages/ui/dist/src/components/List/variants/variantTable.js 129.17 KB (0%)

packages/ui/src/components/RowV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/RowV2/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/RowV2/index.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@9686cf8). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 0fc2523 differs from pull request most recent head 9a57d8a. Consider uploading reports for the commit 9a57d8a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2300   +/-   ##
=======================================
  Coverage        ?   95.43%           
=======================================
  Files           ?      148           
  Lines           ?     3421           
  Branches        ?      451           
=======================================
  Hits            ?     3265           
  Misses          ?      104           
  Partials        ?       52           
Impacted Files Coverage Δ
packages/ui/src/components/RowV2/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9686cf8...9a57d8a. Read the comment docs.

Copy link
Collaborator

@matthprost matthprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is unreadable in dark theme

Screenshot 2023-03-17 at 15 35 19

@fabienhebert fabienhebert merged commit 8eff127 into main Mar 20, 2023
@fabienhebert fabienhebert deleted the feat/row-v2 branch March 20, 2023 14:02
@matthprost matthprost linked an issue Mar 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: layout and grid system
4 participants