Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new component Stack #1908

Merged
merged 3 commits into from
Sep 29, 2022
Merged

feat: new component Stack #1908

merged 3 commits into from
Sep 29, 2022

Conversation

fabienhebert
Copy link
Collaborator

Summary

Type

  • Bug
  • Feature ✅
  • Enhancement
  • Documentation
  • Migration
  • Refactor

Summarise concisely:

What is expected?

Add a new Stack component

@fabienhebert fabienhebert self-assigned this Sep 28, 2022
@fabienhebert fabienhebert marked this pull request as draft September 28, 2022 12:28
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

size-limit report 📦

Path Size
dist/react-datepicker/dist/react-datepicker.min.css.js, dist/src/index.js, dist/react-toastify/dist/ReactToastify.min.css.js, dist/src/helpers/isJSON.js, dist/src/helpers/legend.js, dist/src/helpers/numbers.js, dist/src/helpers/recursivelyGetChildrenString.js, dist/src/theme/index.js, dist/src/utils/animations.js, dist/src/utils/capitalize.js, dist/src/utils/ids.js, dist/src/utils/normalize.js, dist/src/utils/orderBy.js, dist/src/components/ActionBar/index.js, dist/src/components/Alert/index.js, dist/src/components/Avatar/index.js, dist/src/components/Badge/index.js, dist/src/components/BarChart/Tooltip.js, dist/src/components/BarChart/index.js, dist/src/components/BarStack/index.js, dist/src/components/BorderedBox/index.js, dist/src/components/Box/index.js, dist/src/components/Breadcrumbs/index.js, dist/src/components/Bullet/index.js, dist/src/components/Button/index.js, dist/src/components/Checkbox/index.js, dist/src/components/Container/index.js, dist/src/components/DateInput/index.js, dist/src/components/Description/index.js, dist/src/components/DotSteps/index.js, dist/src/components/Expandable/index.js, dist/src/components/Grid/Col.js, dist/src/components/Grid/Grid.js, dist/src/components/Grid/Row.js, dist/src/components/Icon/index.js, dist/src/components/Image/index.js, dist/src/components/Label/index.js, dist/src/components/LineChart/CustomLegend.js, dist/src/components/LineChart/Tooltip.js, dist/src/components/LineChart/helpers.js, dist/src/components/LineChart/index.js, dist/src/components/Link/index.js, dist/src/components/List/Cell.js, dist/src/components/List/LoadingPlaceholder.js, dist/src/components/List/SelectBar.js, dist/src/components/List/SortIcon.js, dist/src/components/List/context.js, dist/src/components/List/index.js, dist/src/components/Loader/index.js, dist/src/components/MarkDown/index.js, dist/src/components/Menu/Item.js, dist/src/components/Menu/index.js, dist/src/components/Modal/index.js, dist/src/components/NavigationStepper/index.js, dist/src/components/Notice/index.js, dist/src/components/Pagination/getPageNumbers.js, dist/src/components/Pagination/index.js, dist/src/components/Pagination/usePagination.js, dist/src/components/PaginationV2/getPageNumbers.js, dist/src/components/PaginationV2/index.js, dist/src/components/PasswordCheck/index.js, dist/src/components/PasswordStrengthMeter/index.js, dist/src/components/Pentagon/index.js, dist/src/components/PieChart/Legends.js, dist/src/components/PieChart/Tooltip.js, dist/src/components/PieChart/index.js, dist/src/components/PieChart/patterns.js, dist/src/components/Placeholder/Block.js, dist/src/components/Placeholder/Blocks.js, dist/src/components/Placeholder/BoxWithIcon.js, dist/src/components/Placeholder/Donut.js, dist/src/components/Placeholder/IconPlaceholder.js, dist/src/components/Placeholder/Line.js, dist/src/components/Placeholder/List.js, dist/src/components/Placeholder/Slider.js, dist/src/components/Placeholder/index.js, dist/src/components/ProgressBar/index.js, dist/src/components/ProgressionButton/index.js, dist/src/components/Radio/index.js, dist/src/components/RichSelect/index.js, dist/src/components/ScrollView/index.js, dist/src/components/SelectNumber/index.js, dist/src/components/SelectableCard/index.js, dist/src/components/Separator/index.js, dist/src/components/Slider/index.js, dist/src/components/Sphere/index.js, dist/src/components/Stack/index.js, dist/src/components/StateBar/index.js, dist/src/components/Status/index.js, dist/src/components/StealthCopiable/index.js, dist/src/components/StepList/index.js, dist/src/components/Stepper/index.js, dist/src/components/SwitchButton/FocusOverlay.js, dist/src/components/SwitchButton/index.js, dist/src/components/Table/index.js, dist/src/components/Tabs/Tab.js, dist/src/components/Tabs/TabMenu.js, dist/src/components/Tabs/TabMenuItem.js, dist/src/components/Tabs/TabsContext.js, dist/src/components/Tabs/index.js, dist/src/components/Tag/index.js, dist/src/components/Tags/index.js, dist/src/components/TagsPoplist/index.js, dist/src/components/Text/index.js, dist/src/components/TextBox/index.js, dist/src/components/TimeInput/index.js, dist/src/components/Toaster/index.js, dist/src/components/Toggle/index.js, dist/src/components/Tooltip/helpers.js, dist/src/components/Tooltip/index.js, dist/src/components/TooltipIcon/index.js, dist/src/components/Touchable/index.js, dist/src/components/UnitInput/index.js, dist/src/components/VerificationCode/index.js, dist/src/components/VolumeSize/index.js, dist/src/theme/tokens/dark.js, dist/src/theme/tokens/light.js, dist/src/utils/responsive/Breakpoint.js, dist/src/utils/responsive/utilities.js, dist/src/components/List/variants/index.js, dist/src/components/List/variants/variantExplorer.js, dist/src/components/List/variants/variantProduct.js, dist/src/components/List/variants/variantTable.js 0 B (-100% 🔽)
dist/src/index.js, dist/react-datepicker/dist/react-datepicker.min.css.js, dist/react-toastify/dist/ReactToastify.min.css.js, dist/src/helpers/isJSON.js, dist/src/helpers/legend.js, dist/src/helpers/numbers.js, dist/src/helpers/recursivelyGetChildrenString.js, dist/src/theme/index.js, dist/src/utils/animations.js, dist/src/utils/capitalize.js, dist/src/utils/ids.js, dist/src/utils/normalize.js, dist/src/utils/orderBy.js, dist/src/components/ActionBar/index.js, dist/src/components/Alert/index.js, dist/src/components/Avatar/index.js, dist/src/components/Badge/index.js, dist/src/components/BarChart/Tooltip.js, dist/src/components/BarChart/index.js, dist/src/components/BarStack/index.js, dist/src/components/BorderedBox/index.js, dist/src/components/Box/index.js, dist/src/components/Breadcrumbs/index.js, dist/src/components/Bullet/index.js, dist/src/components/Button/index.js, dist/src/components/Checkbox/index.js, dist/src/components/Container/index.js, dist/src/components/DateInput/index.js, dist/src/components/Description/index.js, dist/src/components/DotSteps/index.js, dist/src/components/Expandable/index.js, dist/src/components/Grid/Col.js, dist/src/components/Grid/Grid.js, dist/src/components/Grid/Row.js, dist/src/components/Icon/index.js, dist/src/components/Image/index.js, dist/src/components/Label/index.js, dist/src/components/LineChart/CustomLegend.js, dist/src/components/LineChart/Tooltip.js, dist/src/components/LineChart/helpers.js, dist/src/components/LineChart/index.js, dist/src/components/Link/index.js, dist/src/components/List/Cell.js, dist/src/components/List/LoadingPlaceholder.js, dist/src/components/List/SelectBar.js, dist/src/components/List/SortIcon.js, dist/src/components/List/context.js, dist/src/components/List/index.js, dist/src/components/Loader/index.js, dist/src/components/MarkDown/index.js, dist/src/components/Menu/Item.js, dist/src/components/Menu/index.js, dist/src/components/Modal/index.js, dist/src/components/NavigationStepper/index.js, dist/src/components/Notice/index.js, dist/src/components/Pagination/getPageNumbers.js, dist/src/components/Pagination/index.js, dist/src/components/Pagination/usePagination.js, dist/src/components/PaginationV2/getPageNumbers.js, dist/src/components/PaginationV2/index.js, dist/src/components/PasswordCheck/index.js, dist/src/components/PasswordStrengthMeter/index.js, dist/src/components/Pentagon/index.js, dist/src/components/PieChart/Legends.js, dist/src/components/PieChart/Tooltip.js, dist/src/components/PieChart/index.js, dist/src/components/PieChart/patterns.js, dist/src/components/Placeholder/Block.js, dist/src/components/Placeholder/Blocks.js, dist/src/components/Placeholder/BoxWithIcon.js, dist/src/components/Placeholder/Donut.js, dist/src/components/Placeholder/IconPlaceholder.js, dist/src/components/Placeholder/Line.js, dist/src/components/Placeholder/List.js, dist/src/components/Placeholder/Slider.js, dist/src/components/Placeholder/index.js, dist/src/components/ProgressBar/index.js, dist/src/components/ProgressionButton/index.js, dist/src/components/Radio/index.js, dist/src/components/RichSelect/index.js, dist/src/components/ScrollView/index.js, dist/src/components/SelectNumber/index.js, dist/src/components/SelectableCard/index.js, dist/src/components/Separator/index.js, dist/src/components/Slider/index.js, dist/src/components/Sphere/index.js, dist/src/components/Stack/index.js, dist/src/components/StateBar/index.js, dist/src/components/Status/index.js, dist/src/components/StealthCopiable/index.js, dist/src/components/StepList/index.js, dist/src/components/Stepper/index.js, dist/src/components/SwitchButton/FocusOverlay.js, dist/src/components/SwitchButton/index.js, dist/src/components/Table/index.js, dist/src/components/Tabs/Tab.js, dist/src/components/Tabs/TabMenu.js, dist/src/components/Tabs/TabMenuItem.js, dist/src/components/Tabs/TabsContext.js, dist/src/components/Tabs/index.js, dist/src/components/Tag/index.js, dist/src/components/Tags/index.js, dist/src/components/TagsPoplist/index.js, dist/src/components/Text/index.js, dist/src/components/TextBox/index.js, dist/src/components/TimeInput/index.js, dist/src/components/Toaster/index.js, dist/src/components/Toggle/index.js, dist/src/components/Tooltip/helpers.js, dist/src/components/Tooltip/index.js, dist/src/components/TooltipIcon/index.js, dist/src/components/Touchable/index.js, dist/src/components/UnitInput/index.js, dist/src/components/VerificationCode/index.js, dist/src/components/VolumeSize/index.js, dist/src/theme/tokens/dark.js, dist/src/theme/tokens/light.js, dist/src/utils/responsive/Breakpoint.js, dist/src/utils/responsive/utilities.js, dist/src/components/List/variants/index.js, dist/src/components/List/variants/variantExplorer.js, dist/src/components/List/variants/variantProduct.js, dist/src/components/List/variants/variantTable.js 121.07 KB (+100% 🔺)

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1908 (80d5ad2) into main (b2c469b) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   95.80%   95.68%   -0.12%     
==========================================
  Files         119      122       +3     
  Lines        3122     3036      -86     
  Branches      424      424              
==========================================
- Hits         2991     2905      -86     
  Misses         95       95              
  Partials       36       36              
Impacted Files Coverage Δ
src/components/Stack/index.tsx 100.00% <100.00%> (ø)
src/components/Grid/Col.tsx 91.30% <0.00%> (-1.29%) ⬇️
src/components/BarChart/index.tsx 80.00% <0.00%> (-1.25%) ⬇️
src/components/Slider/index.tsx 48.00% <0.00%> (-1.02%) ⬇️
src/components/RichSelect/index.tsx 90.99% <0.00%> (-0.68%) ⬇️
src/components/ProgressBar/index.tsx 91.66% <0.00%> (-0.65%) ⬇️
src/components/VerificationCode/index.tsx 55.05% <0.00%> (-0.50%) ⬇️
src/components/PieChart/index.tsx 91.30% <0.00%> (-0.37%) ⬇️
src/components/List/index.tsx 93.39% <0.00%> (-0.25%) ⬇️
src/components/Tags/index.tsx 92.85% <0.00%> (-0.17%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1dbc7...80d5ad2. Read the comment docs.

Copy link
Contributor

@baptisteArno baptisteArno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@fabienhebert fabienhebert force-pushed the feat/Stack branch 2 times, most recently from 1995068 to fed2de9 Compare September 28, 2022 14:51
@fabienhebert fabienhebert marked this pull request as ready for review September 28, 2022 14:55
src/components/Stack/index.tsx Outdated Show resolved Hide resolved
src/components/Stack/index.tsx Outdated Show resolved Hide resolved
@chambo-e chambo-e merged commit 2fd5892 into main Sep 29, 2022
@chambo-e chambo-e deleted the feat/Stack branch September 29, 2022 13:11
scaleway-bot pushed a commit that referenced this pull request Sep 29, 2022
## [0.198.0](v0.197.0...v0.198.0) (2022-09-29)

### ⚙️ Features

* new component Stack ([#1908](#1908)) ([2fd5892](2fd5892))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 0.198.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matthprost matthprost linked an issue Sep 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: layout and grid system
4 participants