Skip to content

feat(k8s): kosmos: add-external-node command #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Apr 8, 2025

Closes #2955

Left to-do:

  • Doc review
  • Verify remote history

@Mia-Cross Mia-Cross added the k8s Kubernetes Kapsule issues, bugs and feature requests label Apr 8, 2025
@Mia-Cross Mia-Cross self-assigned this Apr 8, 2025
@Mia-Cross Mia-Cross changed the title K8s add external node feat(k8s): kosmos: add-external-node command Apr 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 31.86813% with 62 lines in your changes missing coverage. Please review.

Project coverage is 55.27%. Comparing base (5bf53e0) to head (ccca392).
Report is 595 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/k8s/v1/custom_pool.go 31.11% 61 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (ccca392). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (ccca392)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4651       +/-   ##
===========================================
- Coverage   75.45%   55.27%   -20.18%     
===========================================
  Files         202      309      +107     
  Lines       44323    78993    +34670     
===========================================
+ Hits        33444    43666    +10222     
- Misses       9653    33926    +24273     
- Partials     1226     1401      +175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the k8s_add_external_node branch 2 times, most recently from 56c54d7 to 53a116f Compare April 14, 2025 08:55
@Mia-Cross Mia-Cross force-pushed the k8s_add_external_node branch from 53a116f to ccca392 Compare April 17, 2025 13:46
@Mia-Cross Mia-Cross marked this pull request as ready for review April 17, 2025 13:46
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners April 17, 2025 13:46
@remyleone remyleone added this pull request to the merge queue Apr 17, 2025
Merged via the queue into scaleway:master with commit 52b3e99 Apr 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a way to easily add a node to a kosmos cluster
3 participants