Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented May 30, 2023

Improvement for #2792
Also added a shim to disable this prompt for wasm/js build.
Soon we should be able to remove those shim as they were added to container/console and will be added to bubbletea

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #3151 (9fcc8de) into master (9d076c3) will decrease coverage by 0.05%.
The diff coverage is 26.96%.

@@            Coverage Diff             @@
##           master    #3151      +/-   ##
==========================================
- Coverage   75.83%   75.78%   -0.05%     
==========================================
  Files         171      173       +2     
  Lines       37416    37719     +303     
==========================================
+ Hits        28374    28585     +211     
- Misses       8036     8103      +67     
- Partials     1006     1031      +25     
Impacted Files Coverage Δ
internal/core/testing.go 65.82% <0.00%> (-0.31%) ⬇️
internal/interactive/list.go 0.00% <0.00%> (ø)
internal/interactive/test.go 57.69% <0.00%> (-4.81%) ⬇️
internal/namespaces/init/prompt.go 69.56% <79.31%> (+52.54%) ⬆️
internal/namespaces/init/init.go 68.26% <100.00%> (+9.69%) ⬆️

... and 5 files with indirect coverage changes

@Codelax Codelax force-pushed the feat/init-prompt-projects branch from fd5b149 to e19d016 Compare May 30, 2023 12:50
@Codelax Codelax marked this pull request as draft May 30, 2023 13:55
@Codelax Codelax force-pushed the feat/init-prompt-projects branch from 1edc0d4 to 3ad7e38 Compare May 30, 2023 13:58
autocomplete does not exist for powershell
@Codelax Codelax force-pushed the feat/init-prompt-projects branch from 3ad7e38 to 715fc8a Compare May 30, 2023 14:13
@Codelax Codelax marked this pull request as ready for review May 31, 2023 13:08
@remyleone remyleone added this pull request to the merge queue May 31, 2023
Merged via the queue into scaleway:master with commit 4f4d36a May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants