Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(risc): check device tree, avoid oom #4153

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(risc): check device tree, avoid oom #4153

wants to merge 4 commits into from

Conversation

pbraun9
Copy link
Contributor

@pbraun9 pbraun9 commented Dec 31, 2024 •
edited
Loading

  • workaround fatal error: th1520-lichee-cluster-4a-16g.dts: No such file or directory
  • building fails when there is no thread limit

pbraun9 and others added 2 commits December 31, 2024 10:02
@pbraun9
use updated device tree, avoid oom
ccee81c 
workaround `fatal error: th1520-lichee-cluster-4a-16g.dts: No such file or directory`
fix(riscv): minimize the changes
c73aa6e
@pbraun9 pbraun9 requested a review from bene2k1 as a code owner December 31, 2024 07:03
@pbraun9 pbraun9 changed the title use updated device tree, avoid oom fix(risc): use updated device tree, avoid oom Dec 31, 2024
@bene2k1 bene2k1 self-assigned this Dec 31, 2024
@bene2k1 bene2k1 added do not merge PR that shouldn't be merged before a specific date (eg release) status: tech review Waiting for technical review labels Dec 31, 2024
@pbraun9
Copy link
Contributor Author

pbraun9 commented Dec 31, 2024

no, th1520-lichee-pi-4a-16g.dts is not the right device tree, sorry. but where to find th1520-lpi4a-cluster-16gb.dts ?

@pbraun9 pbraun9 closed this Dec 31, 2024
@pbraun9 pbraun9 reopened this Jan 1, 2025
@pbraun9
Copy link
Contributor Author

pbraun9 commented Jan 1, 2025

the th1520-lichee-cluster-4a-16g.dts device tree is not available just yet for kernel 6.6.66 in the th1520-lts default branch, but it is still available and unsupported on older code bases e.g. branches th1520-master (6.8) and th1520-mainline (6.9).

@pbraun9 pbraun9 changed the title fix(risc): use updated device tree, avoid oom fix(risc): check device tree, avoid oom Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcirinosclwy jcirinosclwy jcirinosclwy approved these changes

@bene2k1 bene2k1 Awaiting requested review from bene2k1 bene2k1 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@bene2k1 bene2k1

Labels
do not merge PR that shouldn't be merged before a specific date (eg release) status: tech review Waiting for technical review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbraun9 @jcirinosclwy @bene2k1