Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bare-metal): rename RV1 page and document kernel update options #3455

Conversation

gilbsgilbs
Copy link
Contributor

Your checklist for this pull request

Description

  • rename RV1 page
  • document kernel update options

@gilbsgilbs gilbsgilbs marked this pull request as ready for review July 9, 2024 12:27
Copy link
Contributor

@nerda-codes nerda-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this link isn't used anywhere else in the documentation? If we change the name of the file without updating potential docs where we refer to this page, we may have broken links.

@gilbsgilbs
Copy link
Contributor Author

Have you checked that this link isn't used anywhere else in the documentation? If we change the name of the file without updating potential docs where we refer to this page, we may have broken links.

I've already opened an MR on the website to add a redirection from the old page to the new (!2339). We can deploy it sometimes after the next content update. I haven't found any outdated link in the docs content.

@gilbsgilbs gilbsgilbs marked this pull request as draft July 12, 2024 13:42
@github-actions github-actions bot added the status: draft Work in progress - do not merge or review label Jul 12, 2024
@gilbsgilbs
Copy link
Contributor Author

gilbsgilbs commented Jul 12, 2024

Drafting this PR as I had a few remarks from my team. done

@gilbsgilbs gilbsgilbs force-pushed the int-feat-baremetal-rv1-kernel-upgrade-options branch 4 times, most recently from 8350987 to 08ad024 Compare July 12, 2024 14:50
@gilbsgilbs gilbsgilbs marked this pull request as ready for review July 12, 2024 15:13
@github-actions github-actions bot removed the status: draft Work in progress - do not merge or review label Jul 12, 2024
@gilbsgilbs gilbsgilbs force-pushed the int-feat-baremetal-rv1-kernel-upgrade-options branch from 08ad024 to ddd9803 Compare July 12, 2024 15:37
@ldecarvalho-doc ldecarvalho-doc merged commit 380f45e into scaleway:main Jul 15, 2024
1 check passed
@gilbsgilbs gilbsgilbs deleted the int-feat-baremetal-rv1-kernel-upgrade-options branch July 15, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants