fix(run-launcher): using id instead job_run_id && job_definition_id (#4)

scaleway · Jan 14, 2024 · 3d68d47 · 3d68d47
1 parent b1ee03a
commit 3d68d47
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/dagster_scaleway/serverless_job_launcher.py b/dagster_scaleway/serverless_job_launcher.py
@@ -147,7 +147,7 @@ def _create_or_update_job_definition(
                 continue
 
             job_def = api.update_job_definition(
-                id=job_def.id,
+                job_definition_id=job_def.id,
                 name=job_def_name,
                 image_uri=docker_image,
                 environment_variables=job_def_env,
@@ -195,7 +195,7 @@ def _launch_serverless_job_with_command(
             client, run, docker_image, command
         )
 
-        job_run = api.start_job_definition(id=job_def.id)
+        job_run = api.start_job_definition(job_definition_id=job_def.id)
 
         self._instance.report_engine_event(
             message=f"Started job definition {job_def.name} with run id {job_run.id} for Dagster run {run.run_id}",
@@ -257,7 +257,7 @@ def _get_scaleway_job_run_from_dagster_run(self, run) -> Optional[scw.JobRun]:
         api = scw.JobsV1Alpha1API(client)
 
         try:
-            return api.get_job_run(id=job_run_id)
+            return api.get_job_run(job_run_id=job_run_id)
         except scaleway.ScalewayException:
             return None
 
@@ -291,7 +291,7 @@ def terminate(self, run_id):
         client = self._get_client(serverless_job_context)
         api = scw.JobsV1Alpha1API(client)
 
-        api.stop_job_run(id=job_run.id)
+        api.stop_job_run(job_run_id=job_run.id)
 
         return True