Fix traversing parents & fix fallback height#5
Open
StephanOsthold wants to merge 2 commits intoscaleflex:masterfrom
Open
Fix traversing parents & fix fallback height#5StephanOsthold wants to merge 2 commits intoscaleflex:masterfrom
StephanOsthold wants to merge 2 commits intoscaleflex:masterfrom
Conversation
When failing to determine the size, the fallback only made sense for the width. Also the left- / right-paddings are not to be subtracted from the height. It may be advisable to subtract the top- / bottom-paddings, however this is out of the scope of this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a typo in the maxCount condition.
Also if no bounding rect is found, the fallback only works for 'width', which can lead to very high images.