Skip to content

WCAG, docstrings, styling, cleanup#37

Merged
declan-scale merged 11 commits intomainfrom
declan-scale/comments-and-cleanup
Nov 4, 2025
Merged

WCAG, docstrings, styling, cleanup#37
declan-scale merged 11 commits intomainfrom
declan-scale/comments-and-cleanup

Conversation

@declan-scale
Copy link
Copy Markdown
Collaborator

Changes

  • Made the CodeMirror change to dark mode
  • Remove some old comments
  • Made the copy button hover state consistent with others
  • Add shadows to messages, input, and agent badges
  • Use better contrasting colors after suggestion by @prassanna-ravishankar, removed unused ones
  • Add aria labels
  • Remove the tabs component (no longer used)
  • Fix dark mode colors to be WCAG AA compliant
  • Add doc strings to sdk hooks

Light mode

image

Dark mode

image

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the UI's accessibility, styling, and code maintainability by implementing WCAG AA compliant color schemes, adding ARIA labels, improving dark mode support, and cleaning up unused code. The changes focus on making the interface more accessible to users with disabilities while improving visual consistency across light and dark modes.

Key changes:

  • Implemented WCAG AA compliant color contrast for dark mode
  • Added ARIA labels to interactive components for screen reader support
  • Removed unused @radix-ui/react-tabs dependency and tabs component
  • Enhanced visual styling with consistent shadows and hover states

Reviewed Changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
agentex-ui/package.json Removed unused @radix-ui/react-tabs dependency
agentex-ui/lib/date-utils.test.ts Removed unnecessary inline comments from test expectations
agentex-ui/hooks/use-tasks.ts Added comprehensive docstrings for task-related hooks
agentex-ui/hooks/use-task-subscription.ts Added docstring explaining real-time subscription functionality
agentex-ui/hooks/use-task-messages.ts Added docstring for message fetching hook
agentex-ui/hooks/use-spans.ts Added docstring for span observability hook
agentex-ui/hooks/use-create-task.ts Added docstrings for task creation and cache update functions
agentex-ui/hooks/use-agents.ts Added docstring for agents list hook
agentex-ui/components/ui/tabs.tsx Deleted entire unused tabs component file
agentex-ui/components/ui/switch.tsx Updated dark mode background color for better contrast
agentex-ui/components/ui/shimmering-text.tsx Replaced hardcoded colors with CSS variables for theme consistency
agentex-ui/components/ui/select.tsx Removed duplicate cursor-default style
agentex-ui/components/ui/button.tsx Updated ghost button hover colors for consistency
agentex-ui/components/agentex/traces-sidebar.tsx Replaced sidebar-specific color classes with standard theme colors
agentex-ui/components/agentex/task-top-bar.tsx Added ARIA labels and replaced inline styles with utility classes
agentex-ui/components/agentex/task-sidebar.tsx Added ARIA labels and updated styling with foreground colors
agentex-ui/components/agentex/task-message-text-content.tsx Added shadow to user messages
agentex-ui/components/agentex/task-button.tsx Refactored conditional classes using cn() utility
agentex-ui/components/agentex/resizable-sidebar.tsx Updated border and hover colors to use standard theme
agentex-ui/components/agentex/prompt-input.tsx Added ARIA labels, fixed CodeMirror dark mode, and added cursor color
agentex-ui/components/agentex/json-viewer.tsx Updated JSON syntax highlighting colors for WCAG AA compliance
agentex-ui/components/agentex/copy-button.tsx Removed default hover styles to allow parent customization
agentex-ui/components/agentex/agents-list.tsx Removed unnecessary filter comment
agentex-ui/components/agentex/agent-badge.tsx Added shadow to selected agent badges
agentex-ui/app/primary-content.tsx Removed inline scroll threshold comment
agentex-ui/app/loading.tsx Removed Suspense wrapper and cleaned up comments
agentex-ui/app/layout.tsx Changed default theme from dark to light
agentex-ui/app/home-view.tsx Updated text color for better contrast
agentex-ui/app/globals.css Comprehensive color system overhaul for WCAG AA compliance
agentex-ui/app/error.tsx Removed unnecessary layout comments
Files not reviewed (1)
  • agentex-ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@MichaelSun48 MichaelSun48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

@declan-scale declan-scale merged commit 29ce381 into main Nov 4, 2025
3 checks passed
@declan-scale declan-scale deleted the declan-scale/comments-and-cleanup branch November 4, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants