Merged
Conversation
f74c758 to
fae61cb
Compare
fae61cb to
a4e2a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Extends the ADK
TasksModulewith task lifecycle management: status transitions (cancel, complete, fail, terminate, timeout), metadata updates, and Temporal workflow querying. Changes span all three layers — module, service, and Temporal activities — following the established dual-path pattern (direct service call vs Temporal activity execution). Well-tested with comprehensive unit tests across all layers.TasksModule:cancel,complete,fail,terminate,timeout,update, andquery_workflowTaskStatusTransitionParams,UpdateTaskParams,QueryWorkflowParamsget_all_activitiesfor Temporal worker discoveryConfidence Score: 4/5
This PR is safe to merge — it adds new functionality without modifying existing behavior, and follows established patterns consistently.
All new code follows the existing dual-path (Temporal vs direct) pattern. Good test coverage across all three layers. No logical errors found. Deducted one point for significant code repetition across the five status transition methods that could benefit from refactoring.
src/agentex/lib/adk/_modules/tasks.py and src/agentex/lib/core/services/adk/tasks.py have significant repetition in the status transition methods.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[TasksModule] -->|in_temporal_workflow?| B{Temporal Workflow?} B -->|Yes| C[ActivityHelpers.execute_activity] B -->|No| D[TasksService] C --> E[TasksActivities] E --> D D --> F[AsyncAgentex Client] subgraph "New Operations" G[cancel / complete / fail / terminate / timeout] H[update by id or name] I[query_workflow] end A --> G A --> H A --> IPrompt To Fix All With AI
Reviews (2): Last reviewed commit: "Add task updates to adk" | Re-trigger Greptile
Context used:
Learnt From
scaleapi/scaleapi#127166