[Fix] support header forwarding for temporal ACP#140
[Fix] support header forwarding for temporal ACP#140prassanna-ravishankar merged 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends header forwarding support to temporal async agents by ensuring request headers are properly passed through the temporal ACP implementation chain. The fix addresses a gap where PR #99 implemented header forwarding for synchronous agents but missed the temporal workflow path.
- Adds request parameter forwarding in the temporal ACP event handler
- Updates TemporalTaskService.send_event method to accept and forward request headers
- Includes comprehensive test coverage for temporal header forwarding scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/agentex/lib/sdk/fastacp/impl/temporal_acp.py | Passes request parameter to temporal task service event handler |
| src/agentex/lib/core/temporal/services/temporal_task_service.py | Adds request parameter to send_event method signature and forwards it to temporal signal payload |
| tests/test_header_forwarding.py | Adds comprehensive test suite for temporal ACP header forwarding functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f6e6b9b to
165b751
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
#99 didn't cover temporal async agents