Skip to content

Example of TypeCheckedTripleEquals mixed in a test class#62

Open
ronanM wants to merge 2 commits into
scalatest:masterfrom
ronanM:patch-1
Open

Example of TypeCheckedTripleEquals mixed in a test class#62
ronanM wants to merge 2 commits into
scalatest:masterfrom
ronanM:patch-1

Conversation

@ronanM

@ronanM ronanM commented Dec 7, 2016

Copy link
Copy Markdown

No description provided.

<span class="stReserved">class</span> MyTest <span class="stReserved">extends</span> FunSuite <span class="stReserved">with</span> Matchers <span class="stReserved">with</span> TypeCheckedTripleEquals {

test("Type checked ===") {
val i : Int = 42

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, but the code convention used in the rest of the file for val declarations would be to remove the space before the : / after the variable name, so val i: Int = 42 maybe?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

val i : Int = 42
val s : String = "42"

i should === (s) // Do not compile because i is an Int and s is a String, great !

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a little confusing, since this isn't really a valid test case, and the code would never compile...does it make more sense to have an example with i !=== (s)?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to show the behaviour of TypeCheckedTripleEquals at compile-time.

@plinlor

plinlor commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

@cla-bot[bot] check

@cla-bot

cla-bot Bot commented Aug 10, 2020

Copy link
Copy Markdown

Hi @ronanM, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

@cla-bot

cla-bot Bot commented Aug 10, 2020

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants