Backport to branch(3.14) : Remove an error message for the replication feature from old versions

[feeblefakie]

This is an automated backport of the following:

• Original PR: Remove an error message for the replication feature from old versions #3247
• Backported commit: 5ad9f8c

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline error handling by removing an outdated error message related to the replication feature from the 3.14 branch. This change, backported from a more recent version, ensures that the codebase remains clean and consistent with current feature sets, eliminating references to deprecated error conditions.

Highlights

• Error Message Removal: The REPLICATION_NOT_ENABLED error message, previously associated with the replication feature, has been removed from the CoreError enum.
• Automated Backport: This pull request is an automated backport of a change from a newer version (original PR Remove an error message for the replication feature from old versions #3247, commit 5ad9f8c) to the 3.14 branch.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports a change to remove an error message related to the replication feature. The change itself is correct and removes the REPLICATION_NOT_ENABLED enum from CoreError.java. My review includes one suggestion to improve code maintainability by adding a comment where the error code was removed. This will clarify why there is a gap in the error code sequence and prevent accidental reuse of the code in the future.

I am having trouble creating individual review comments. Click here to see my feedback.

core/src/main/java/com/scalar/db/common/error/CoreError.java (803-809)

Removing this error code creates a gap in the error code sequence, as 0188 will be missing. While this is preferable to renumbering all subsequent error codes, it can be confusing for future developers. To improve maintainability and prevent accidental reuse of the error code, I suggest leaving a comment to explicitly mark 0188 as intentionally unused.

  // 0188 was used for REPLICATION_NOT_ENABLED, which has been removed.