-
Notifications
You must be signed in to change notification settings - Fork 0
Update versions in version dropdown and banner announcement to 3.12 #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions in version dropdown and banner announcement to 3.12 #1006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the version references from 3.11 to 3.12 in documentation configuration files to reflect the new ScalarDL release.
- Updated version label in Japanese internationalization file
- Updated banner announcement text to reference ScalarDL 3.12
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
i18n/versioned_docs/ja-jp/docusaurus-plugin-content-docs/current.json | Updates version label from 3.11 to 3.12 for Japanese localization |
docusaurus.config.js | Updates announcement banner content to reference ScalarDL 3.12 instead of 3.11 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @josh-wong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request ensures that the documentation site accurately reflects the latest ScalarDL version, 3.12, across both its public-facing announcement banner and the internal versioning metadata used for the version dropdown. This is crucial for providing users with up-to-date information about the current release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the version number from 3.11 to 3.12 in the Docusaurus configuration for the announcement banner and in the Japanese i18n file for the version label. The changes are straightforward and achieve the stated goal. I have one suggestion regarding the announcement banner configuration to improve long-term maintainability for future version updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your quick update.
Description
This PR fixes the versions shown in the version dropdown and banner announcement. When cutting a new release automatically by using Docusaurus, it doesn't automatically update the
current.json
file for i18n docs to show the next release, so it needs to be added manually. In addition, the banner announcement should have been updated from 3.11 to 3.12.Related issues and/or PRs
Changes made
3.11
to3.12
.Checklist
Additional notes (optional)
N/A