-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Completions for requests just before string #22894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
...entation-compiler/test/dotty/tools/pc/tests/completion/CompletionStringContextSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
package dotty.tools.pc.tests.completion | ||
|
||
import dotty.tools.pc.base.BaseCompletionSuite | ||
import org.junit.Test | ||
import dotty.tools.dotc.core.Types.ThisType.raw | ||
|
||
class CompletionStringContextSuite extends BaseCompletionSuite: | ||
@Test | ||
def inScopeSymbol = check( | ||
""" | ||
|object M: | ||
| val VersionRegex = "".r | ||
| VersionRe@@"1234" | ||
""".stripMargin, | ||
"|VersionRegex: Regex".stripMargin | ||
) | ||
|
||
@Test | ||
def workspaceSymbol = check( | ||
""" | ||
|object M: | ||
| ListBuf@@"1234" | ||
""".stripMargin, | ||
""" | ||
|ListBuffer[A](elems: A*): ListBuffer[A] - scala.collection.mutable | ||
|new ListBuffer[A]: ListBuffer[A] - scala.collection.mutable | ||
|ListBuffer - scala.collection.mutable | ||
|""".stripMargin | ||
) | ||
|
||
@Test | ||
def providedSymbol = check( | ||
""" | ||
|object M: | ||
| ra@@"1234" | ||
""".stripMargin, | ||
"|raw(args: Any*): String".stripMargin | ||
) | ||
|
||
// bellow are tests of edits | ||
@Test | ||
def editTest1 = checkEdit( | ||
""" | ||
|object M: | ||
| ra@@"1234" | ||
""".stripMargin, | ||
""" | ||
|object M: | ||
| raw"1234" | ||
|""".stripMargin | ||
) | ||
|
||
@Test | ||
def editTest2 = checkEdit( | ||
""" | ||
|object M: | ||
| printl@@"1234" | ||
""".stripMargin, | ||
""" | ||
|object M: | ||
| println"1234" | ||
|""".stripMargin, | ||
assertSingleItem = false | ||
) | ||
|
||
@Test | ||
def editTest3 = checkEdit( | ||
""" | ||
|object M: | ||
| def select(s: String): String = s | ||
| selec@@"1234" | ||
""".stripMargin, | ||
""" | ||
|object M: | ||
| def select(s: String): String = s | ||
| select"1234" | ||
|""".stripMargin, | ||
assertSingleItem = false | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we show VersionRegex if it doesn't have anything to do with StringContext? Could we have a check that only shows things like
raw
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to show all completions. This is unintended behavior that there were no completions just before string due to String context desugaring. All other completions work like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example you have a string which you want to wrap in Some, and you had no completions at all