Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh: try to support # tags for single Scala version releases again #145

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

Sciss
Copy link
Contributor

@Sciss Sciss commented Dec 4, 2020

No description provided.

@Sciss Sciss mentioned this pull request Dec 4, 2020
@Sciss Sciss requested a review from SethTisue December 5, 2020 12:14
@SethTisue
Copy link
Member

SethTisue commented Dec 5, 2020

I suggest that we not bring this back. It wasn't necessarily a terrible way to do things, but we're doing it differently now in all of the other Scala modules.

The new way to backpublish, as per #112 and #127, is to remove the unwanted matrix entries from .travis.yml, then tag and push the commit (tagged, but not on any branch). I did this recently over at scala/scala-parallel-collections#143 and it worked fine.

Now, you're the lead maintainer here and if you like, you can stick with the old method. But I don't recommend it, because the downside is basically that I can't keep multiple ways of doing this in my head and help maintain multiple ways. We have a bunch of these modules and it's a lot easier to help out with them if they're all the same. (I mean, I wouldn't refuse to answer questions about nonstandard setups, but I wouldn't be available to actually help dig into it if something goes wrong, either.)

@SethTisue
Copy link
Member

P.S. there is now a breadcrumb about this on scala/sbt-scala-module#16

@Sciss
Copy link
Contributor Author

Sciss commented Dec 5, 2020

Ok, I can revert, do the pushing as you say. Can you clear the sonatype staging, so I can go ahead with that?

@Sciss
Copy link
Contributor Author

Sciss commented Dec 5, 2020

I am ready to merge and push the tag

@Sciss Sciss removed the request for review from SethTisue December 5, 2020 21:28
@Sciss Sciss merged commit 973fb6a into scala:work Dec 5, 2020
@SethTisue
Copy link
Member

whoops — this shouldn't have been merged to the work branch — the idea is to tag the commit and push the tag, without pushing the commit to any branch

I pushed reversions to the work branch, so now we're back to normal, I think

@Sciss
Copy link
Contributor Author

Sciss commented Dec 5, 2020

I don't understand. You cannot push a tag if you don't push a corresponding commit? Or should a new branch be created?

@SethTisue
Copy link
Member

The commit should be on no branch at all. It's sufficient that it have an associated tag.

You tag the commit and push the tag: git push origin <tag-name>. (Pushing the tag pushes the commit as well.)

@Sciss
Copy link
Contributor Author

Sciss commented Dec 5, 2020

@SethTisue
Copy link
Member

Yeah, it's a bit odd :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants