-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.sh: try to support # tags for single Scala version releases again #145
Conversation
I suggest that we not bring this back. It wasn't necessarily a terrible way to do things, but we're doing it differently now in all of the other Scala modules. The new way to backpublish, as per #112 and #127, is to remove the unwanted matrix entries from Now, you're the lead maintainer here and if you like, you can stick with the old method. But I don't recommend it, because the downside is basically that I can't keep multiple ways of doing this in my head and help maintain multiple ways. We have a bunch of these modules and it's a lot easier to help out with them if they're all the same. (I mean, I wouldn't refuse to answer questions about nonstandard setups, but I wouldn't be available to actually help dig into it if something goes wrong, either.) |
P.S. there is now a breadcrumb about this on scala/sbt-scala-module#16 |
Ok, I can revert, do the pushing as you say. Can you clear the sonatype staging, so I can go ahead with that? |
I am ready to merge and push the tag |
whoops — this shouldn't have been merged to the I pushed reversions to the |
I don't understand. You cannot push a tag if you don't push a corresponding commit? Or should a new branch be created? |
The commit should be on no branch at all. It's sufficient that it have an associated tag. You tag the commit and push the tag: |
Thanks, I didn't know about that; https://stackoverflow.com/questions/9265278/what-happens-if-i-push-a-tag-for-a-commit-that-hasnt-been-pushed |
Yeah, it's a bit odd :-) |
No description provided.