Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross build with Scala Native #282

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Cross build with Scala Native #282

merged 4 commits into from
Dec 23, 2024

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Dec 20, 2024

Resolves #262

Copy link
Member

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@SethTisue
Copy link
Member

Zero source code changes. Amazing!

Is there any Native-specific documentation we ought to provide as part of this? (like, I don't know... Is configuring the thread pool any different?)

@WojciechMazur
Copy link
Contributor Author

WojciechMazur commented Dec 20, 2024

I believe the configuration should be exactly the same as on the JVM by providing a custom ExecutionContext / ForkJoinPool. The ForkJoinPool default (common) pool is compliant with the JVM (JSR-166 port), the default ExecutionContext is global, so there shouldn't be anything needed to configure.
The only exception could be system properties-based configs (which are missing in this codebase) - these cannot be preconfigured at startup but need to be set at runtime.

@SethTisue SethTisue merged commit 6df961e into main Dec 23, 2024
10 checks passed
@SethTisue SethTisue deleted the build/scala-native branch December 23, 2024 14:43
@SethTisue
Copy link
Member

ticket on rolling a release: #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Scala Native 0.5.x
3 participants