-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance section #1504
Governance section #1504
Changes from 5 commits
507bab4
85eeed6
188aa5c
d880f4c
ae403d9
2f282c0
540d41e
e983985
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
introText: This section is updated every 6 months by the Scala Center. | ||
cards: | ||
- title: "Scala Improvement Process" | ||
description: "The SIP is the primary mechanism for evolving the Scala language." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be good to expand a little bit the description. What about the following?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, but this will take many lines of text, is it ok to go in the expanded section? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally, I find the current There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in the context of being the top of the community page, it adds a lot of vertical space, also the other boxes don't have a similar amount of text, so leading to empty space |
||
expandText: "Process & People" | ||
links: | ||
- text: "This process aims to evolve Scala openly and collaboratively. Anyone from the community is welcome to submit a Scala Improvement Proposal (SIP), which is then reviewed and discussed by a Committee. Every month, the Committee votes on the proposals to accept in the language." | ||
- name: SIP Homepage | ||
url: https://docs.scala-lang.org/sips/index.html | ||
- name: SIP Committee Members | ||
url: https://docs.scala-lang.org/sips/process-specification.html#the-sip-committee | ||
- name: SIP Process Specification | ||
url: https://docs.scala-lang.org/sips/process-specification.html | ||
- title: "Scala 3 Maintenance" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should cover both Scala 2 and Scala 3. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @lrytz can you help us out here? In terms of the maintenance of Scala 2, what resources can we reference for the current process and people involved? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, those are pretty up to date. If you feel anything is missing, let me know. |
||
description: "Managing the Scala 3 compiler, standard library and documentation." | ||
expandText: "Process & People" | ||
links: | ||
- name: Core Maintainers | ||
url: https://github.com/lampepfl/dotty/blob/main/MAINTENANCE.md#compiler | ||
- name: Maintenance Procedures | ||
url: https://github.com/lampepfl/dotty/blob/main/MAINTENANCE.md | ||
Comment on lines
+17
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here too, both links point to the same page. Also, that page dives deep into the issue supervisor role without giving an overview of all the organizations (I see at least LAMP and VirtusLab) involved in the maintenance of the compiler and their respective role. Last, the description above mentions the standard library and the documentation, which are not covered by the links. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This information should probably be added to the MAINTENANCE.md as a separate PR. |
||
- title: "Tooling" | ||
description: "Managing build tools, linters, IDEs, and other tools." | ||
expandText: "Process & People" | ||
links: | ||
- text: "Process and People are TBD, please stay tuned! However you can read below about the Scala Tooling Summit:" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this section should be filled before we merge the PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current status on this is that we've only conducted one Tooling Summit during which no process was adopted. Changing this might be the goal for the next Summit in September. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if there is no “process”, I would expect the Governance section to give more understanding to the readers about which organizations do exist and actively work on the tooling ecosystem. I think we should mention at least VirtusLab with Scala CLI and Metals, and Jetbrains with IntelliJ. |
||
- name: "Scala Tooling Summit of March 2023" | ||
url: https://www.scala-lang.org/blog/2023/04/11/march-2023-scala-tooling-summit.html | ||
- title: "Moderation" | ||
description: "Learn how the Scala community is moderated." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don’t have a concrete suggestion to make, but I think the description should summarize what we see in the links (the fact that there is a moderation team, a code of conduct, etc.). |
||
expandText: "Process & People" | ||
links: | ||
- text: "The Scala community is moderated by the Moderation Team over all the official communication channels. The moderation is governed by the Code of Conduct" | ||
anatoliykmetyuk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: "Moderation Team" | ||
url: https://www.scala-lang.org/conduct/#contact | ||
- name: Code of Conduct | ||
url: https://www.scala-lang.org/conduct/ | ||
- name: "Inclusive Language Guide" | ||
url: https://docs.scala-lang.org/contribute/inclusive-language-guide.html | ||
- name: "Communication Channels" | ||
url: https://docs.scala-lang.org/community/ | ||
- title: "Scala Center" | ||
description: "The organization fostering the Scala community, education, and OSS library development." | ||
expandText: "Learn More" | ||
links: | ||
- name: "Homepage" | ||
url: https://scala.epfl.ch/ | ||
- name: Team | ||
url: https://scala.epfl.ch/team.html | ||
- name: "Advisory Board" | ||
url: https://github.com/scalacenter/advisoryboard#the-scala-center-advisory-board | ||
- name: "5 Year Report" | ||
url: https://scala.epfl.ch/records/first-five-years/ | ||
- title: "Scala 2 Maintenance" | ||
description: "Who maintains the Scala 2 compiler?" | ||
expandText: "Process & People" | ||
links: | ||
- name: "Contribution Process" | ||
url: "https://github.com/scala/scala#how-to-contribute" | ||
- name: "Core Maintainers" | ||
url: "https://github.com/scala/scala#get-in-touch" | ||
Comment on lines
+54
to
+61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for adding this card. I am a bit confused because its content is pretty different from the Scala 3 Maintenance card. Would it be possible to make them more similar? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would require making the actual processes similar :) which is not the case. In the case of Scala 3, we have an Issue Supervisor role, which is specced as an actual procedure that we follow weekly to monitor the new issues, identify critical ones, and schedule them in a milestone for fixing. For Scala 2, the link I specified doesn't describe a maintenance procedure but rather how to push your own contribution. Since the nature of the two documents is so different, I don't think we can't label the Scala 2 link as Maintenance Procedures in the same way the Scala 3 one is called that way. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
// GOVERNANCE | ||
//------------------------------------------------ | ||
//------------------------------------------------ | ||
|
||
.governance { | ||
// background: $gray-nutshell; | ||
|
||
.vertical-buttons-list { | ||
@include display(flex); | ||
@include flex-direction(column); | ||
@include justify-content(space-between); | ||
padding: 15px 0; | ||
li { | ||
margin-bottom: 10px; | ||
} | ||
// @include align-items(center); | ||
// @include justify-content(flex-start); | ||
} | ||
|
||
.button-expand { | ||
text-align: center; | ||
display: block; | ||
} | ||
|
||
.button-more { | ||
font-size: $font-size-small; | ||
padding: 5px; | ||
cursor: pointer; | ||
} | ||
|
||
.scala-items-list { | ||
.items-menu { | ||
.scala-item { | ||
@include span-columns(4); | ||
@include omega(3n); | ||
|
||
@include display(flex); | ||
@include flex-direction(column); | ||
// @include align-items(center); | ||
@include justify-content(space-between); | ||
padding: 15px 10px; | ||
text-align: center; | ||
transition: $base-transition; | ||
// border: 1px solid $gray-light; | ||
margin-top: 15px; | ||
@include bp(large) { | ||
@include span-columns(12); | ||
} | ||
|
||
min-height: 150px; | ||
|
||
h4 { | ||
font-size: $font-size-h3; | ||
color: #000; | ||
text-transform: uppercase; | ||
font-family: $base-font-family; | ||
margin-bottom: 10px; | ||
} | ||
|
||
p { | ||
font-size: $font-size-medium; | ||
} | ||
|
||
&.active { | ||
background: $gray-light; | ||
} | ||
} | ||
|
||
.items-content { | ||
background: $gray-light; | ||
transition: $base-transition; | ||
|
||
.items-code { | ||
display: none; | ||
padding: 5px 0; | ||
} | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is not necessary. We should anyway update the content as frequently as necessary (sometimes more than once every six months, but most of the time I guess this will not change within a year).